Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hikaricp dashboard #113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hecomp
Copy link
Contributor

@hecomp hecomp commented Sep 7, 2023

Description

What does this PR do?
added hikaricp dashboard

PR checklist

Please confirm the following items:

  • At least one screenshot of the proposed dashboard is included in this PR. If you're proposing substantive changes to queries or new queries then please ensure your screenshot shows relevant data.
  • All chart names are in Title case.
  • All query names are lower case letters, beginning the first query of each chart as "a" and proceeding alphabetically ... "b", "c", etcetera.
Screenshot 2023-09-07 at 5 49 24 PM

@nslaughter
Copy link
Collaborator

Thank you @hecomp.
For these cases where we don't have metric streams to validate the charts, we'll need to make that apparent and distinguish them from other cases.
Please add a README to the module that includes...

  • a link to docs where you sourced the metrics documentation
  • either (a) a link to the example that provides the data or (b) a simple statement that this is based on metric names from docs

@hecomp
Copy link
Contributor Author

hecomp commented Sep 13, 2023

Thank you @hecomp. For these cases where we don't have metric streams to validate the charts, we'll need to make that apparent and distinguish them from other cases. Please add a README to the module that includes...

  • a link to docs where you sourced the metrics documentation
  • either (a) a link to the example that provides the data or (b) a simple statement that this is based on metric names from docs

https://github.com/lightstep/integrations/blob/e7f654adb3d52ba24be62f97e2b7f746b1d30468/collector/hikaricp/dashboards/overview/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants