feature: Resources page with routing and list of resource types

[llorentelemmc]

No description provided.

[mburri]

see commit a9f6e80 as an example on how to improve this

[mburri]

I assume that this is new code (or taken from one of the view beans?)

Try to use modern java - with lambdas and streams (maybe optionals) - basically, there is almost never a reason to use for loops.

so this could look like this:

 public List<ResourceTypeEntity> getPredefinedResourceTypes() throws NotFoundException {
        List<ResourceTypeEntity> predefinedResourceTypes = resourceTypeDomainService.getResourceTypes()
                .stream()
                .filter(resourceTypeEntity -> resourceTypeEntity == null && ResourceType.createByResourceType(resourceTypeEntity, null).isDefaultResourceType())
                .collect(Collectors.toList());

        if (predefinedResourceTypes.isEmpty()) {
            throw new NotFoundException("No predefined resource types found");
        }
        return predefinedResourceTypes;
    }

[mburri]

I also think that the NotFoundException should not be thrown here. The exception is only relevant for the rest point (where the NotFoundExcpetionMapper exists).

It might be perfectly valid to get an empty list for other use cases in the future. Additionally - it will throw an error in the frontend. The more I think about it - just remove the exception - an empty list should not return an HTTP status 404.

[mburri]

GET /thing/:id should return 404 if the thing with the given id was not found
GET /thing should not return 404 if the list is empty

[mburri]

some as above - empty lists should not return a 404

[mburri]

replace with stream().map()

[mburri]

replace with stream().map()

[mburri]

replace with stream().map()

[mburri]

It would also have been nice to split this PR along the stories:

• create page skeleton and routing in the frontend
• show List of ResourceTypes

[BeriBoss]

Suggested change

	@if (expandedResourceTypeId === resourceType.id) {
	@if (resourceType.hasChildren && expandedResourceTypeId === resourceType.id) {

[BeriBoss]

Suggestion above:
Because otherwise you can also expand those that have no children, only then an "empty list" or simply no list is displayed, but you can see that something has been expanded in the UI.