Merge pull request #560 from alexislefebvre/remove-paratest-run

Remove “paratest:run” command
liip · Feb 16, 2020 · 8edbbc2 · 8edbbc2
2 parents 6024b27 + a09fb5c
commit 8edbbc2
Show file tree

Hide file tree

Showing 13 changed files with 9 additions and 252 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,11 @@
 # Changelog
 
-## 3.0 [TBA]
+## 4.0
+
+### Removed
+ * Drop support of `paratest:run`
+
+## 3.0
 This new major version introduces a number of breaking changes; see the [upgrade guide](UPGRADE-3.0.md) for more details.
 
 ### Added
@@ -14,7 +19,7 @@ This new major version introduces a number of breaking changes; see the [upgrade
 ### Removed
  * Removed fixtures loading in favor of https://github.com/liip/LiipTestFixturesBundle
 
-## 2.0 [TBA]
+## 2.0
 This new major version introduces a number of breaking changes; see the [upgrade guide](UPGRADE-2.0.md) for more details.
 
 ### Added

diff --git a/README.md b/README.md
@@ -23,7 +23,6 @@ Documentation
 * [Caveats](doc/caveats.md)
 
 To run tests in parallel:
-* [Paratest](doc/paratest.md)
 * [Fastest](doc/fastest.md)
 
 [Travis Master]: https://travis-ci.org/liip/LiipFunctionalTestBundle

diff --git a/composer.json b/composer.json
@@ -33,7 +33,6 @@
         "symfony/framework-bundle": "4.3.0"
     },
     "suggest": {
-        "brianium/paratest": "Required when using paratest to parallelize tests",
         "liip/test-fixtures-bundle": "Efficient loading of Doctrine fixtures in functional test-cases for Symfony applications"
     },
     "autoload": {
@@ -51,7 +50,7 @@
     },
     "extra": {
         "branch-alias": {
-            "dev-master": "3.x-dev"
+            "dev-master": "4.x-dev"
         }
     }
 }
diff --git a/doc/installation.md b/doc/installation.md
@@ -12,7 +12,7 @@ Installation
     following command to download the latest stable version of this bundle:
 
     ```bash
-    $ composer require --dev liip/functional-test-bundle:^3.0.0
+    $ composer require --dev liip/functional-test-bundle:^4.0.0
     ```
 
     This command requires you to have Composer installed globally, as explained

diff --git a/doc/paratest.md b/doc/paratest.md
diff --git a/src/Command/RunParatestCommand.php b/src/Command/RunParatestCommand.php
diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -58,17 +58,6 @@ public function getConfigTreeBuilder(): TreeBuilder
                         ->end()
                     ->end()
                 ->end()
-                ->arrayNode('paratest')
-                    ->addDefaultsIfNotSet()
-                    ->children()
-                        ->scalarNode('process')
-                            ->defaultValue(5)
-                        ->end()
-                        ->scalarNode('phpunit')
-                            ->defaultValue('./bin/phpunit')
-                        ->end()
-                    ->end()
-                ->end()
             ->end()
         ;
 

diff --git a/src/DependencyInjection/LiipFunctionalTestExtension.php b/src/DependencyInjection/LiipFunctionalTestExtension.php
@@ -31,7 +31,6 @@ public function load(array $configs, ContainerBuilder $container): void
         $config = $this->processConfiguration(new Configuration(), $configs);
 
         $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
-        $loader->load('commands.xml');
         $loader->load('functional_test.xml');
 
         if (interface_exists('Symfony\Component\Validator\Validator\ValidatorInterface')) {

diff --git a/src/Resources/config/commands.xml b/src/Resources/config/commands.xml
diff --git a/tests/AppConfig/config.yml b/tests/AppConfig/config.yml
@@ -14,6 +14,3 @@ liip_functional_test:
     authentication:
         username: "foobar"
         password: "12341234"
-    paratest:
-        process: 3
-        phpunit: 'vendor/bin/phpunit'
diff --git a/tests/Command/ParatestCommandTest.php b/tests/Command/ParatestCommandTest.php
diff --git a/tests/DependencyInjection/ConfigurationConfigTest.php b/tests/DependencyInjection/ConfigurationConfigTest.php
@@ -44,8 +44,6 @@ public function parametersProvider(): array
             ['query.max_query_count', 1],
             ['authentication.username', 'foobar'],
             ['authentication.password', '12341234'],
-            ['paratest.process', 3],
-            ['paratest.phpunit', 'vendor/bin/phpunit'],
         ];
     }
 }
diff --git a/tests/DependencyInjection/ConfigurationTest.php b/tests/DependencyInjection/ConfigurationTest.php
@@ -60,8 +60,6 @@ public function parametersProvider(): array
             ['query.max_query_count', null],
             ['authentication.username', ''],
             ['authentication.password', ''],
-            ['paratest.process', 5],
-            ['paratest.phpunit', './bin/phpunit'],
         ];
     }
 }