Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add tests for PHP 8.4 #322

Merged
merged 1 commit into from
Nov 12, 2024
Merged

chore: Add tests for PHP 8.4 #322

merged 1 commit into from
Nov 12, 2024

Conversation

Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Oct 4, 2024 •
edited
Loading

needs update of laminas/laminas-code

@alexislefebvre
Copy link
Collaborator

Thanks for the PR.

Let's wait for updates of the dependencies then:

@Chris53897 Chris53897 closed this Nov 4, 2024
@Chris53897 Chris53897 reopened this Nov 4, 2024
@Chris53897
Copy link
Contributor Author

Chris53897 commented Nov 4, 2024 •
edited
Loading

Waiting for Seldaek/monolog#1920 => DONE

@Chris53897 Chris53897 closed this Nov 12, 2024
@Chris53897 Chris53897 reopened this Nov 12, 2024
@Chris53897
Copy link
Contributor Author

The failing Testrun looks unrelated

@alexislefebvre alexislefebvre merged commit 2b810cd into liip:2.x Nov 12, 2024
33 of 36 checks passed
@alexislefebvre
Copy link
Collaborator

Thanks!

@alexislefebvre
Copy link
Collaborator

The failing Testrun looks unrelated

Running it again fixed the issue 🤷:

@Chris53897 Chris53897 deleted the patch-1 branch November 22, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chris53897 @alexislefebvre