-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple export as default #3
Multiple export as default #3
Conversation
@lijunle Any plan to merge these? These are critical to us in Atom community (atom-community/atom#67 (comment)). If you can't maintain this repository anymore, we have an active fork here: We would appreciate it if you can give us access to release the patches under the original name. I have planned a couple of patches myself which totally removes the issues: |
@aminya I am not actively working on this project any more. It is great that you and the community can continue the maintenance of this package. I am totally ok to add you as the owner then you can push the release from your fork. Try to connect @59naga and @ljharb to see if they have any concerns. If they don’t have further concerns within 1 day, I will update the permissions. |
@aminya i'd love to rebase this PR, but i don't have access to your atom-ide-community fork. Can you add me? |
@ljharb my repo is just a fork with 1 more fix ahead of @52naga ‘s original repo.
I don’t have permission to access @52naga ‘s original repo. My idea is, set up a new repo for this plugin (maybe use atom-ide-community fork), then update the package.json and publish new version to point to the new repo. Both you and I have the access to publish the new versions to npm. |
@lijunle sure, but this one has issues and PRs, and it'd be nice to preserve that rather than littering github with multiple forks that don't redirect to each other :-) |
@lijunle That would be awesome. I'm happy to continue fixing the edge cases of this software. We have a tone of mixed ES5/ES6 packages that we can't convert to ES6.
@ljharb I sent you an invitation. This branch is already rebased, and it is also on the master of my fork.
Both works for me. I'd prefer to transfer the repository to the organization, so everyone can contribute to. |
I'd be happy to make an org for it. |
@aminya i joined, but don't seem to be on the repo yet. (it's not rebased yet because there's a merge commit in it) |
I gave you proper access. Let's wait until we decide about the way to go. Maybe we need to remove that repo.
That's fine to me. I don't mind about the merge commit. |
b856b07
to
40ed1c1
Compare
59naga#82 (comment)