Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple export as default #3

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

aminya
Copy link

@aminya aminya commented Sep 7, 2020

@aminya aminya changed the title Multiple export as default + remove chokidar Multiple export as default Sep 7, 2020
@aminya
Copy link
Author

aminya commented Sep 8, 2020

@lijunle Any plan to merge these? These are critical to us in Atom community (atom-community/atom#67 (comment)). If you can't maintain this repository anymore, we have an active fork here:
https://github.com/atom-ide-community/babel-plugin-add-module-exports

We would appreciate it if you can give us access to release the patches under the original name.

I have planned a couple of patches myself which totally removes the issues:
atom-community#4

@lijunle
Copy link
Owner

lijunle commented Sep 8, 2020

@aminya I am not actively working on this project any more. It is great that you and the community can continue the maintenance of this package. I am totally ok to add you as the owner then you can push the release from your fork.

Try to connect @59naga and @ljharb to see if they have any concerns. If they don’t have further concerns within 1 day, I will update the permissions.

@ljharb
Copy link
Collaborator

ljharb commented Sep 8, 2020

I'll be happy to review, merge, and release the PR; I'd deferred while I thought @lijunle was still maintaining.

@lijunle if you're not interested in maintaining it further, i'd be happy to accept a repo transfer, so i can administer CI checks.

@ljharb
Copy link
Collaborator

ljharb commented Sep 8, 2020

@aminya i'd love to rebase this PR, but i don't have access to your atom-ide-community fork. Can you add me?

@lijunle
Copy link
Owner

lijunle commented Sep 8, 2020

@ljharb my repo is just a fork with 1 more fix ahead of @52naga ‘s original repo.

59naga/babel-plugin-add-module-exports@master...lijunle:master

I don’t have permission to access @52naga ‘s original repo. My idea is, set up a new repo for this plugin (maybe use atom-ide-community fork), then update the package.json and publish new version to point to the new repo. Both you and I have the access to publish the new versions to npm.

@ljharb
Copy link
Collaborator

ljharb commented Sep 8, 2020

@lijunle sure, but this one has issues and PRs, and it'd be nice to preserve that rather than littering github with multiple forks that don't redirect to each other :-)

@aminya
Copy link
Author

aminya commented Sep 8, 2020

I am totally ok to add you as the owner then you can push the release from your fork.

@lijunle That would be awesome. I'm happy to continue fixing the edge cases of this software. We have a tone of mixed ES5/ES6 packages that we can't convert to ES6.

@aminya i'd love to rebase this PR, but i don't have access to your atom-ide-community fork. Can you add me?

@ljharb I sent you an invitation. This branch is already rebased, and it is also on the master of my fork.

it'd be nice to preserve that rather than littering github with multiple forks that don't redirect to each other :-)

Both works for me. I'd prefer to transfer the repository to the organization, so everyone can contribute to.

@ljharb
Copy link
Collaborator

ljharb commented Sep 8, 2020

I'd be happy to make an org for it.

@ljharb
Copy link
Collaborator

ljharb commented Sep 8, 2020

@aminya i joined, but don't seem to be on the repo yet. (it's not rebased yet because there's a merge commit in it)

@aminya
Copy link
Author

aminya commented Sep 8, 2020

@aminya i joined, but don't seem to be on the repo yet.

I gave you proper access. Let's wait until we decide about the way to go. Maybe we need to remove that repo.

(it's not rebased yet because there's a merge commit in it)

That's fine to me. I don't mind about the merge commit.

@ljharb ljharb force-pushed the multiple-export-as-default branch from b856b07 to 40ed1c1 Compare September 8, 2020 22:09
@ljharb ljharb merged commit 40ed1c1 into lijunle:master Sep 8, 2020
@ljharb ljharb deleted the multiple-export-as-default branch September 8, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants