Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env variables for xkb-data paths #332

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

man0lis
Copy link
Contributor

@man0lis man0lis commented Sep 14, 2024

The xkb-data crate used hard-coded paths for locating the xkb rule XML files. Since version 0.2.1 there is a way to overwrite these hard-coded paths using the X11_BASE_RULES_XML and X11_EXTRA_RULES_XML environment variables. This patch adds these variables to the wrappers of cosmic-settings and comsic-greeter.

This should fix issue #74 for cosmic-settings. cosmic-greeter should start working as soon as the cosmic devs bump its version of the xkb-data crate.

The xkb-data crate used a hard-coded path for locating the xkb rule XML
files. Since version 0.2.1 there is a way to overwrite these hard-coded
paths using the X11_BASE_RULES_XML and X11_EXTRA_RULES_XML environment
variables. This patch adds these variables to the wrappers of
cosmic-settings and comsic-greeter.
Copy link
Owner

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! It looks like cosmic-applets also needs the same treatment, but I'll add that after this PR

@lilyinstarlight lilyinstarlight enabled auto-merge (squash) September 14, 2024 20:12
@lilyinstarlight lilyinstarlight merged commit ea50ed0 into lilyinstarlight:main Sep 14, 2024
5 checks passed
@man0lis man0lis deleted the add_xkb_data_envvars branch September 28, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants