attempt to get build working with older windows

lilyvanoekel · Oct 6, 2024 · 6b32836 · 6b32836
1 parent a939c6e
commit 6b32836
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 25 deletions.
diff --git a/.github/workflows/build-cmajor-windows.yaml b/.github/workflows/build-cmajor-windows.yaml
@@ -5,7 +5,7 @@ on:
 
 jobs:
   build:
-    runs-on: windows-latest
+    runs-on: windows-2019
     steps:
       - name: Checkout Cmajor
         uses: actions/checkout@v4
@@ -25,7 +25,7 @@ jobs:
       - name: Build Cmajor
         run: |
           cd cmajor
-          cmake -Bbuild -G "Visual Studio 17 2022" -A x64 .
+          cmake -Bbuild -G "Visual Studio 16 2019" -A x64 .
           cmake --build build --config Release
 
       - name: Upload Cmajor Executable as Artifact

diff --git a/.github/workflows/build-windows.yaml b/.github/workflows/build-windows.yaml
@@ -10,12 +10,9 @@ on:
 
 jobs:
   build:
-    runs-on: windows-latest
+    runs-on: windows-2019
 
     steps:
-      - name: Install WebView2 Runtime
-        run: choco install microsoft-edge-webview2
-
       - name: Checkout Cmajor
         uses: actions/checkout@v4
         with:
@@ -49,30 +46,30 @@ jobs:
           path: clap
           fetch-depth: 1
 
-      - name: Checkout JUCE
-        uses: actions/checkout@v4
-        with:
-          repository: juce-framework/JUCE
-          path: juce
-          fetch-depth: 1
+      # - name: Checkout JUCE
+      #   uses: actions/checkout@v4
+      #   with:
+      #     repository: juce-framework/JUCE
+      #     path: juce
+      #     fetch-depth: 1
 
       - name: Set Corrected Current Directory Path
         shell: powershell
         run: |
           $currentDir = (Get-Location).Path -replace '\\', '/'
           echo "CURRENT_DIR=$currentDir" >> $env:GITHUB_ENV
 
-      - name: Set JUCE environment variable
-        run: echo "JUCE_PATH=${{ env.CURRENT_DIR }}/juce" >> $GITHUB_ENV
+      # - name: Set JUCE environment variable
+      #   run: echo "JUCE_PATH=${{ env.CURRENT_DIR }}/juce" >> $GITHUB_ENV
 
       - name: Generate CLAP Plugin
         run: ./cmajor/build/tools/command/Release/cmaj.exe generate --target=clap --output=${{ github.workspace }}\\oscilluna-clap --clapIncludePath=${{ github.workspace }}\\clap\\include --cmajorIncludePath=${{ github.workspace }}\\cmajor\\include ${{ github.workspace }}\\src\\Oscilluna.cmajorpatch
 
       # - name: Generate Web Assembly
       #   run: ./cmajor/build/tools/command/Release/cmaj.exe generate --target=webaudio --output=${{ github.workspace }}\\oscilluna-web --cmajorIncludePath=${{ github.workspace }}\\cmajor\\include ${{ github.workspace }}\\src\\Oscilluna.cmajorpatch
 
-      - name: Generate Juce
-        run: ./cmajor/build/tools/command/Release/cmaj.exe generate --target=juce --output=./oscilluna-juce --cmajorIncludePath=${{ env.CURRENT_DIR }}/cmajor/include ./src/Oscilluna.cmajorpatch
+      # - name: Generate Juce
+      #   run: ./cmajor/build/tools/command/Release/cmaj.exe generate --target=juce --output=./oscilluna-juce --cmajorIncludePath=${{ env.CURRENT_DIR }}/cmajor/include ./src/Oscilluna.cmajorpatch
 
       # - name: Directory Tree for oscilluna-web
       #   shell: pwsh
@@ -86,19 +83,20 @@ jobs:
           cmake -B build -DCLAP_INCLUDE_PATH="${{ github.workspace }}\\clap\\include" -DCMAKE_BUILD_TYPE=Release
           cmake --build build --config Release
 
-      - name: Build JUCE
-        run: |
-          cd oscilluna-juce
-          cmake -B build -DJUCE_PATH="${{ env.CURRENT_DIR }}/juce" -DCMAKE_BUILD_TYPE=Release
-          cmake --build build --config Release
+      # - name: Build JUCE
+      #   run: |
+      #     cd oscilluna-juce
+      #     cmake -B build -DJUCE_PATH="${{ env.CURRENT_DIR }}/juce" -DCMAKE_BUILD_TYPE=Release
+      #     cmake --build build --config Release
 
       - name: Create release
         uses: softprops/action-gh-release@v2
         with:
-          files: |
-            oscilluna-clap/build/Release/Oscilluna.clap
-            oscilluna-juce/build/Oscilluna_artefacts/Release/VST3/Oscilluna.vst3/Contents/x86_64-win/Oscilluna.vst3
-            oscilluna-juce/build/Oscilluna_artefacts/Release/Standalone/Oscilluna.exe
+          files: oscilluna-clap/build/Release/Oscilluna.clap
+          # files: |
+          #   oscilluna-clap/build/Release/Oscilluna.clap
+          #   oscilluna-juce/build/Oscilluna_artefacts/Release/VST3/Oscilluna.vst3/Contents/x86_64-win/Oscilluna.vst3
+          #   oscilluna-juce/build/Oscilluna_artefacts/Release/Standalone/Oscilluna.exe
           tag_name: ${{ github.ref_name }}
           name: Oscilluna CLAP Plugin (Windows) - ${{ github.ref_name }}
           prerelease: false