Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushPlatformValidationScenario: exit early if some failure endanger connection state #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

PushPlatformValidationScenario: exit early if some failure endanger connection state #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...a-2.12/org/apache/james/gatling/jmap/rfc8621/scenari/PushPlatformValidationScenario.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,15 @@ class PushPlatformValidationScenario(minMessagesInMailbox: Int,
.exec(JmapEmail.getState()
.check(statusOk, noError, JmapEmail.saveStateAs(emailState)))
.exec(queryEmails(queryParameters = openpaasEmailQueryParameters(inbox))))
.exec(websocketConnect)
.exec(websocketConnect).exitHereIfFailed
.exec(enablePush)
.during(duration) {
exec(ping)
.exec(randomSwitch(
2.0 -> inboxHomeLoading.inboxHomeLoading,
8.0 -> selectArbitrary.selectArbitrary,
5.0 -> JmapEmail.submitEmails(recipientFeeder),
30.0 -> openArbitrary.openArbitrary,
5.0 -> JmapEmail.submitEmails(recipientFeeder).exitHereIfFailed,
30.0 -> openArbitrary.openArbitrary.exitHereIfFailed,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why those 2 actions specifically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a look at the Gatling simulation log: gatling_log.zip, I see these suspect log:

REQUEST		submitEmails	1665053694055	1665053696510	KO	j.i.IOException: Premature close
REQUEST		submitEmails	1665053694332	1665053696517	KO	j.i.IOException: Premature close
REQUEST		emailGet	1665053788417	1665053788509	KO	j.i.IOException: Premature close
REQUEST		emailGet	1665053692357	1665053693488	KO	j.i.IOException: Premature close

Which has not happened before 0.6.3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to understand why :)

10.0 -> flagUpdate,
15.0 -> getNewState,
30.0 -> exec())
Expand Down