Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate v0.11.3-patch4-dev to master branch #2911

Merged
merged 80 commits into from
Jun 11, 2024
Merged

Migrate v0.11.3-patch4-dev to master branch #2911

merged 80 commits into from
Jun 11, 2024

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Jun 5, 2024 •
edited
Loading

  • Display warning dialog when pick/drag&drop/share attachment/inline in composer
  • Show sending dialog when send/save email
  • Selectable in blue bar
  • Add button Mail to attendees to open composer with to all attendees
  • Improve composer UI
  • Signature
  • Communicating I18n to remote servers

Blocker

dab246 and others added 30 commits June 5, 2024 12:20
@dab246
TF-2644 Display warning dialog when pick file exceeded maximum size i…
dc855a2 
…n composer
@dab246
TF-2644 Display warning dialog when drag & drop file exceeded maximum…
b5442a1 
… size in composer

Signed-off-by: dab246 <[email protected]>
@dab246
TF-2644 Display warning dialog when share file exceeded maximum size …
e126b98 
…in composer

Signed-off-by: dab246 <[email protected]>
@dab246
TF-2644 Display warning dialog when drag from other email exceeded ma…
ed8b47e 
…ximum size in composer

Signed-off-by: dab246 <[email protected]>
@dab246
TF-2644 Display tooltip message when attachments exceeded maximum siz…
9d003ec 
…e in composer

Signed-off-by: dab246 <[email protected]>
@dab246
TF-2644 Handle total size exceeded maximum size when drag & drop mult…
2f7dd89 
…iple file to composer
@hoangdat @dab246
TF-2644 Remove wrong text in intl_vi.arb
be35b16
@dab246
TF-2667 Use Username replace UserProfile
568309b
@dab246
TF-2667 Create ApplicationVersionWidget to display app version
1902231
@dab246
TF-2667 Move the creation of mailbox request id to the data layer
873272e 
Signed-off-by: dab246 <[email protected]>
@dab246
TF-2667 Show sending message dialog when click send button
8dbcbf5
@dab246
TF-2667 Replace isSendEmailLoading to ButtonState
ff677ea
@dab246
TF-2667 Show confirm dialog when send email failed
bda34ec
@dab246
TF-2667 Show confirm dialog when click close composer
3b3d300 
Signed-off-by: dab246 <[email protected]>
@dab246
TF-2667 Show saving message dialog when preform save action
8351b26
@dab246
TF-2667 Refresh thread & mailbox view when saving message success
67954f0
@dab246
TF-2667 Handle save message to cache when reload page
ddb924e
@dab246
TF-2667 Add cancel button in progress send message dialog
3a9d5ba
@dab246
TF-2667 Add cancel button in progress saving message to drafts dialog
21f3fcf
@dab246
TF-2667 Validate email in recipient form before send email
2a26967
@dab246
TF-2667 Remove log unnecessary
92edb7a
@dab246
TF-2667 Clean WARNING/INFO when run dart analyze
b4a29fe
@dab246
TF-2667 Write unit test for Domain & MailAddress class
299883c
@dab246
TF-2667 Fix crash when click on From me in search filter
0fa8a98
@dab246
TF-2667 Remove composer cache after close composer view
6d890bb
@dab246
TF-2667 Handle error better when perform save as drafts
9d10ffb
@dab246
TF-2667 Fix width size inline image in email view after send email
1d9fcc3
@dab246
TF-2667 Remove function not used
8f19d48
@dab246
TF-2667 Prevent close sending/saving dialog when click system back on…
fe79469 
… mobile
@dab246
TF-2667 Store email to sending queue when sending with no connection …
0b77f74 
…on mobile
@dab246 dab246 requested a review from hoangdat June 5, 2024 09:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/2911.

@dab246 dab246 mentioned this pull request Jun 5, 2024
Open
@tddang-linagora
Copy link
Contributor

tddang-linagora commented Jun 6, 2024 •
edited
Loading

@tddang-linagora Test iOS

  • Display warning dialog when pick/drag&drop/share attachment/inline in composer
    • Pick attachment tested: OK
    • Pick inline: OK (Not supported)
  • Show sending dialog when send/save email
  • Selectable in blue bar
  • Add button Mail to attendees to open composer with to all attendees
  • Improve composer UI
  • Signature
  • Communicating I18n to remote servers

@tddang-linagora
Copy link
Contributor

Composer inline image with >10mb doesn't have warning dialog

composer-inline-10mb.mov

@dab246
Copy link
Member Author

dab246 commented Jun 7, 2024

Composer inline image with >10mb doesn't have warning dialog

composer-inline-10mb.mov

Dialog warning about files >10 MB only checks for attachment, not inline image

@hoangdat
Copy link
Member

hoangdat commented Jun 7, 2024 •
edited by tddang-linagora
Loading

  • @tddang-linagora please help me verify memory-leak for this changes. Thank you

@hoangdat
Copy link
Member

hoangdat commented Jun 7, 2024 •
edited
Loading

  • can not reply event successfully in iOS (yes/no/maybe)

@dab246
Copy link
Member Author

dab246 commented Jun 7, 2024 •
edited by hoangdat
Loading

  • can not reply event successfully in iOS (yes/no/maybe)

Checked that it was a server error when making CalendarEvent requests

Screenshot 2024-06-07 at 12 50 56

@tddang-linagora
Copy link
Contributor

  • @tddang-linagora please help me verify memory-leak for this changes. Thank you

Pick inline image OK
Screenshot 2024-06-10 at 09 14 24

@tddang-linagora
Copy link
Contributor

@dab246 Drag & drop image bug

Screen.Recording.2024-06-10.at.09.17.20.mov

@tddang-linagora
Copy link
Contributor

tddang-linagora commented Jun 10, 2024 •
edited by hoangdat
Loading

Composer - Pick attachment memory leak #2919
Screenshot 2024-06-10 at 09 36 40

@tddang-linagora
Copy link
Contributor

  • @tddang-linagora please help me verify memory-leak for this changes. Thank you

View heavy email OK
Screenshot 2024-06-10 at 09 46 35

This was referenced Jun 10, 2024
Closed
Merged
@hoangdat
Copy link
Member

  • create a separate branch from this branch with Firebase analytics to verify other problem

@hoangdat hoangdat changed the base branch from master to refactor June 11, 2024 06:58
@hoangdat hoangdat merged commit 2a862e5 into refactor Jun 11, 2024
16 of 18 checks passed
@hoangdat hoangdat deleted the migrate_dev_to_master_5Jun branch November 6, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat Awaiting requested review from hoangdat

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dab246 @tddang-linagora @hoangdat @chibenwa