Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-3023 SMime signature validation #3061

Merged
merged 3 commits into from
Aug 9, 2024
Merged

TF-3023 SMime signature validation #3061

merged 3 commits into from
Aug 9, 2024

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Aug 5, 2024 •
edited
Loading

Issue

#3023
#3031

Resolved

  • Good signature:
Screen.Recording.2024-08-05.at.16.47.57.mov
  • Bad signature:
Screen.Recording.2024-08-05.at.16.48.47.mov

@dab246 dab246 requested a review from tddang-linagora August 5, 2024 10:10
@dab246 dab246 requested a review from hoangdat August 5, 2024 10:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/3061.

@dab246 dab246 requested a review from hoangdat August 6, 2024 02:15
@dab246
Copy link
Member Author

dab246 commented Aug 7, 2024 •
edited
Loading

  • Rebase

@hoangdat
Copy link
Member

hoangdat commented Aug 7, 2024

please rebase

@dab246 dab246 force-pushed the enhancement/tf-3023-smime-signature-validation branch from c5fa66c to 2053c3a Compare August 7, 2024 04:51
@dab246
Copy link
Member Author

dab246 commented Aug 7, 2024

please rebase

Done

@dab246 dab246 requested a review from hoangdat August 7, 2024 04:52
@hoangdat
Copy link
Member

hoangdat commented Aug 9, 2024 •
edited by dab246
Loading

  • rebase with refactor branch
  • test with real EML from MU

@dab246 dab246 force-pushed the enhancement/tf-3023-smime-signature-validation branch from 2053c3a to ba77a3b Compare August 9, 2024 06:07
@dab246 dab246 changed the base branch from sprint_25_flutter_3_22_2 to refactor August 9, 2024 06:07
@dab246
Copy link
Member Author

dab246 commented Aug 9, 2024 •
edited by hoangdat
Loading

  • rebase with refactor branch
  • test with real EML from MU

@hoangdat eml file from MU withEmail/get does not return header containing X-SMIME-Status

@hoangdat hoangdat merged commit 420799b into refactor Aug 9, 2024
3 checks passed
@Arsnael
Copy link
Member

Arsnael commented Aug 27, 2024 •
edited
Loading

@hoangdat eml file from MU withEmail/get does not return header containing X-SMIME-Status

That's likely because you need to have the SmimeCheckSignature mailet added in the mailetcontainer.xml file for tmail-backend with the cert from MU, so that when the backend is processing the eml file example you got from MU, it adds the header X-SMIME-Status which you can read

@hoangdat
Copy link
Member

hi @Arsnael , v0.13.0 was release in canary-tmail (linagora) or mail.stg.lin-saas.com (TWP). Can you take a look and test for SMime? Thanks

@dab246 dab246 mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tddang-linagora tddang-linagora tddang-linagora approved these changes

@hoangdat hoangdat Awaiting requested review from hoangdat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dab246 @hoangdat @Arsnael @tddang-linagora