Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3042 Public asset with create and edit identity #3067

Merged

Conversation

tddang-linagora
Copy link
Contributor

@tddang-linagora tddang-linagora commented Aug 6, 2024

Issue

Demo

create.public.asset.and.display.successfully.mov
Screen.Recording.2024-08-12.at.15.57.50.mov

Copy link

github-actions bot commented Aug 6, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/3067.

@tddang-linagora tddang-linagora force-pushed the feature/TF-3042-public-asset-with-create-or-edit-identity branch from 896e346 to 264cff8 Compare August 7, 2024 08:32
@tddang-linagora tddang-linagora force-pushed the feature/TF-3042-public-asset-with-create-or-edit-identity branch from e9f1366 to 61ea8d4 Compare August 7, 2024 09:04
@tddang-linagora tddang-linagora force-pushed the feature/TF-3042-public-asset-with-create-or-edit-identity branch from 9e35b58 to cd24b14 Compare August 9, 2024 03:32
@tddang-linagora tddang-linagora changed the base branch from sprint_25_flutter_3_22_2 to refactor August 9, 2024 03:32
@tddang-linagora tddang-linagora marked this pull request as ready for review August 12, 2024 02:50
@tddang-linagora tddang-linagora changed the title [WIP] TF-3042 Public asset with create and edit identity TF-3042 Public asset with create and edit identity Aug 12, 2024
@tddang-linagora tddang-linagora force-pushed the feature/TF-3042-public-asset-with-create-or-edit-identity branch from e1c1223 to efb3a80 Compare August 12, 2024 03:26
@hoangdat
Copy link
Member

hoangdat commented Aug 12, 2024

  • please add demo for mobile too

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hoangdat
Copy link
Member

please rebase

@hoangdat
Copy link
Member

hoangdat commented Aug 13, 2024

  • test again the case of dereference public asset
  1. create identity with public-asset-1
  2. edit this identity: remove public-asset-1

@hoangdat hoangdat merged commit a3d17b3 into refactor Aug 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants