-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-3042 Public asset with create and edit identity #3067
Merged
hoangdat
merged 7 commits into
refactor
from
feature/TF-3042-public-asset-with-create-or-edit-identity
Aug 14, 2024
Merged
TF-3042 Public asset with create and edit identity #3067
hoangdat
merged 7 commits into
refactor
from
feature/TF-3042-public-asset-with-create-or-edit-identity
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has been deployed to https://linagora.github.io/tmail-flutter/3067. |
896e346
to
264cff8
Compare
e9f1366
to
61ea8d4
Compare
9e35b58
to
cd24b14
Compare
dab246
reviewed
Aug 12, 2024
lib/features/identity_creator/presentation/identity_creator_controller.dart
Outdated
Show resolved
Hide resolved
dab246
reviewed
Aug 12, 2024
lib/features/manage_account/presentation/profiles/identities/identities_controller.dart
Outdated
Show resolved
Hide resolved
e1c1223
to
efb3a80
Compare
|
hoangdat
reviewed
Aug 12, 2024
lib/features/public_asset/presentation/public_asset_controller.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Aug 12, 2024
lib/features/public_asset/domain/extensions/string_to_public_asset_extension.dart
Show resolved
Hide resolved
hoangdat
reviewed
Aug 12, 2024
lib/features/identity_creator/presentation/identity_creator_controller.dart
Show resolved
Hide resolved
hoangdat
reviewed
Aug 12, 2024
lib/features/identity_creator/presentation/identity_creator_controller.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Aug 12, 2024
lib/features/public_asset/domain/usecase/remove_identity_from_public_assets_interactor.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Aug 12, 2024
lib/features/manage_account/presentation/profiles/identities/identities_controller.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Aug 13, 2024
test/features/public_asset/domain/extensions/string_to_public_asset_extension_test.dart
Show resolved
Hide resolved
dab246
reviewed
Aug 13, 2024
lib/features/public_asset/domain/usecase/clean_up_public_assets_interactor.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Aug 13, 2024
lib/features/public_asset/domain/extensions/public_asset_extension.dart
Outdated
Show resolved
Hide resolved
dab246
reviewed
Aug 13, 2024
dab246
reviewed
Aug 13, 2024
dab246
reviewed
Aug 13, 2024
lib/features/identity_creator/presentation/identity_creator_controller.dart
Outdated
Show resolved
Hide resolved
dab246
reviewed
Aug 13, 2024
dab246
reviewed
Aug 13, 2024
test/features/public_asset/domain/extensions/string_to_public_asset_extension_test.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Aug 13, 2024
lib/features/manage_account/presentation/profiles/identities/identities_controller.dart
Outdated
Show resolved
Hide resolved
dab246
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
hoangdat
approved these changes
Aug 13, 2024
hoangdat
approved these changes
Aug 13, 2024
please rebase |
96c32ab
to
95f1333
Compare
|
hoangdat
reviewed
Aug 13, 2024
lib/features/public_asset/domain/usecase/add_identity_to_public_assets_interactor.dart
Show resolved
Hide resolved
hoangdat
reviewed
Aug 13, 2024
lib/features/public_asset/domain/usecase/remove_identity_from_public_assets_interactor.dart
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Demo
create.public.asset.and.display.successfully.mov
Screen.Recording.2024-08-12.at.15.57.50.mov