Skip to content

TF-3611 E2E Trash & spam empty and recover #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: patrol-integration-test
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions backend-docker/deletedMessageVault.properties
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# ============================================= Deleted Messages Vault Configuration ==================================

enabled=true
restoreLocation=Restored-Messages

# Retention period for your deleted messages into the vault, after which they expire and can be potentially cleaned up
# Optional, default 1y
# retentionPeriod=1y
2 changes: 2 additions & 0 deletions backend-docker/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ services:
- ./mailetcontainer.xml:/root/conf/mailetcontainer.xml
- ./imapserver.xml:/root/conf/imapserver.xml
- ./jmap.properties:/root/conf/jmap.properties
- ./deletedMessageVault.properties:/root/conf/deletedMessageVault.properties
- ./listeners.xml:/root/conf/listeners.xml
- ./linagora-ecosystem.properties:/root/conf/linagora-ecosystem.properties
- ../provisioning/integration_test/provisioning.sh:/root/conf/integration_test/provisioning.sh
- ../provisioning/integration_test/eml:/root/conf/integration_test/eml
Expand Down
7 changes: 7 additions & 0 deletions backend-docker/listeners.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?xml version="1.0"?>

<listeners>
<preDeletionHook>
<class>org.apache.james.vault.DeletedMessageVaultHook</class>
</preDeletionHook>
</listeners>
6 changes: 5 additions & 1 deletion integration_test/mixin/scenario_utils_mixin.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import 'package:jmap_dart_client/jmap/identities/identity.dart';
import 'package:jmap_dart_client/jmap/jmap_request.dart';
import 'package:jmap_dart_client/jmap/mail/email/email_address.dart';
import 'package:jmap_dart_client/jmap/mail/email/set/set_email_method.dart';
import 'package:jmap_dart_client/jmap/mail/mailbox/mailbox.dart';
import 'package:model/model.dart';
import 'package:path_provider/path_provider.dart';
import 'package:tmail_ui_user/features/composer/domain/state/upload_attachment_state.dart';
Expand All @@ -33,6 +34,7 @@ mixin ScenarioUtilsMixin {
List<ProvisioningEmail> provisioningEmails, {
bool refreshEmailView = true,
bool requestReadReceipt = true,
Role? sentLocation,
}) async {
ComposerBindings().dependencies();

Expand All @@ -58,7 +60,9 @@ mixin ScenarioUtilsMixin {
emailContent: provisioningEmail.content,
toRecipients: {EmailAddress(null, provisioningEmail.toEmail)},
outboxMailboxId: mailboxDashBoardController.outboxMailbox?.mailboxId,
sentMailboxId: mailboxDashBoardController.mapDefaultMailboxIdByRole[PresentationMailbox.roleSent],
sentMailboxId: mailboxDashBoardController.mapDefaultMailboxIdByRole[
sentLocation ?? PresentationMailbox.roleSent
],
identity: identity,
attachments: attachments,
hasRequestReadReceipt: requestReadReceipt,
Expand Down
12 changes: 12 additions & 0 deletions integration_test/robots/mailbox_menu_robot.dart
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,16 @@ class MailboxMenuRobot extends CoreRobot {
})
.tap();
}

Future<void> tapRecoverDeletedMessages() async {
await $(AppLocalizations().recoverDeletedMessages).tap();
}

Future<void> tapConfirmRecoverDeletedMessages() async {
if (await $.native.isPermissionDialogVisible(timeout: const Duration(seconds: 2))) {
await $.native.grantPermissionWhenInUse();
}
Comment on lines +79 to +81
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to wait for permission here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-04-09 at 14 26 17

await $(AppLocalizations().restore).tap();
await $.pumpAndSettle();
}
}
31 changes: 31 additions & 0 deletions integration_test/robots/thread_robot.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import 'package:tmail_ui_user/features/base/widget/compose_floating_button.dart'
import 'package:tmail_ui_user/features/thread/presentation/thread_view.dart';
import 'package:tmail_ui_user/features/thread/presentation/widgets/email_tile_builder.dart';
import 'package:tmail_ui_user/features/thread/presentation/widgets/scroll_to_top_button_widget.dart';
import 'package:tmail_ui_user/main/localizations/app_localizations.dart';

import '../base/core_robot.dart';

Expand Down Expand Up @@ -60,4 +61,34 @@ class ThreadRobot extends CoreRobot {
Future<void> selectStarredFilter() async {
await $(#filter_email_starred).tap();
}

Future<void> tapEmptyTrashBanner() async {
await $(AppLocalizations().empty_trash_now).tap();
}

Future<void> confirmEmptyTrash() async {
await $(AppLocalizations().delete_all).tap();
}

Future<void> tapEmptySpamBanner() async {
await $(AppLocalizations().deleteAllSpamEmailsNow).waitUntilVisible();
await $(AppLocalizations().deleteAllSpamEmailsNow).tap();
}

Future<void> confirmEmptySpam() async {
await $(AppLocalizations().delete_all).tap();
}

Future<void> tapEmptyTrashAfterLongPress() async {
await $(AppLocalizations().emptyTrash).tap();
}

Future<void> tapConfirmEmptyTrashAfterLongPress() async {
await $(AppLocalizations().delete).tap();
await $.pumpAndSettle(duration: const Duration(seconds: 2));
}

Future<void> tapEmptySpamAfterLongPress() async {
await $(AppLocalizations().deleteAllSpamEmails).tap();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:model/mailbox/presentation_mailbox.dart';
import 'package:tmail_ui_user/features/thread/presentation/widgets/banner_delete_all_spam_emails_widget.dart';
import 'package:tmail_ui_user/main/localizations/app_localizations.dart';

import '../../base/base_test_scenario.dart';
import '../../models/provisioning_email.dart';
import '../../robots/mailbox_menu_robot.dart';
import '../../robots/thread_robot.dart';

class EmptyAndRecoverSpamScenario extends BaseTestScenario {
const EmptyAndRecoverSpamScenario(super.$);

@override
Future<void> runTestLogic() async {
const toEmail = String.fromEnvironment('BASIC_AUTH_EMAIL');
const subject = 'spam and recover';

final threadRobot = ThreadRobot($);
final mailboxMenuRobot = MailboxMenuRobot($);
final appLocalizations = AppLocalizations();

await provisionEmail(
[ProvisioningEmail(
toEmail: toEmail,
subject: subject,
content: '',
)],
sentLocation: PresentationMailbox.roleJunk,
);

await threadRobot.openMailbox();
await mailboxMenuRobot.openFolderByName(
appLocalizations.spamMailboxDisplayName,
);
await threadRobot.tapEmptySpamBanner();
await threadRobot.confirmEmptySpam();
await _expectSpamBannerInvisible();

await threadRobot.openMailbox();
await mailboxMenuRobot.longPressMailboxWithName(
appLocalizations.trashMailboxDisplayName,
);
await mailboxMenuRobot.tapRecoverDeletedMessages();
await mailboxMenuRobot.tapConfirmRecoverDeletedMessages();
await threadRobot.openMailbox();
await mailboxMenuRobot.openFolderByName(
appLocalizations.recoveredMailboxDisplayName,
);
await _expectEmailWithSubjectVisible(subject);
}

Future<void> _expectSpamBannerInvisible() async {
await $(#spam_banner_not_visible).waitUntilExists();
expect($(BannerDeleteAllSpamEmailsWidget).visible, false);
}

Future<void> _expectEmailWithSubjectVisible(String subject) async {
await expectViewVisible($(subject));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:model/mailbox/presentation_mailbox.dart';
import 'package:tmail_ui_user/features/thread/presentation/widgets/banner_empty_trash_widget.dart';
import 'package:tmail_ui_user/main/localizations/app_localizations.dart';

import '../../base/base_test_scenario.dart';
import '../../models/provisioning_email.dart';
import '../../robots/mailbox_menu_robot.dart';
import '../../robots/thread_robot.dart';

class EmptyAndRecoverTrashScenario extends BaseTestScenario {
const EmptyAndRecoverTrashScenario(super.$);

@override
Future<void> runTestLogic() async {
const toEmail = String.fromEnvironment('BASIC_AUTH_EMAIL');
const subject = 'trash and recover';

final threadRobot = ThreadRobot($);
final mailboxMenuRobot = MailboxMenuRobot($);
final appLocalizations = AppLocalizations();

await provisionEmail(
[ProvisioningEmail(
toEmail: toEmail,
subject: subject,
content: '',
)],
sentLocation: PresentationMailbox.roleTrash,
);

await threadRobot.openMailbox();
await mailboxMenuRobot.openFolderByName(
appLocalizations.trashMailboxDisplayName,
);
await threadRobot.tapEmptyTrashBanner();
await threadRobot.confirmEmptyTrash();
await _expectTrashBannerInvisible();

await threadRobot.openMailbox();
await mailboxMenuRobot.longPressMailboxWithName(
appLocalizations.trashMailboxDisplayName,
);
await mailboxMenuRobot.tapRecoverDeletedMessages();
await mailboxMenuRobot.tapConfirmRecoverDeletedMessages();
await threadRobot.openMailbox();
await mailboxMenuRobot.openFolderByName(
appLocalizations.recoveredMailboxDisplayName,
);
await _expectEmailWithSubjectVisible(subject);
}

Future<void> _expectTrashBannerInvisible() async {
await $(#trash_banner_not_visible).waitUntilExists();
expect($(BannerEmptyTrashWidget).visible, false);
}

Future<void> _expectEmailWithSubjectVisible(String subject) async {
await expectViewVisible($(subject));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:model/mailbox/presentation_mailbox.dart';
import 'package:tmail_ui_user/features/mailbox/presentation/widgets/trailing_mailbox_item_widget.dart';
import 'package:tmail_ui_user/features/thread/presentation/widgets/banner_delete_all_spam_emails_widget.dart';
import 'package:tmail_ui_user/main/localizations/app_localizations.dart';

import '../../base/base_test_scenario.dart';
import '../../models/provisioning_email.dart';
import '../../robots/mailbox_menu_robot.dart';
import '../../robots/thread_robot.dart';

class LongPressEmptyAndRecoverSpamScenario extends BaseTestScenario {
const LongPressEmptyAndRecoverSpamScenario(super.$);

@override
Future<void> runTestLogic() async {
const toEmail = String.fromEnvironment('BASIC_AUTH_EMAIL');
const subject = 'long press spam';

final threadRobot = ThreadRobot($);
final mailboxMenuRobot = MailboxMenuRobot($);
final appLocalizations = AppLocalizations();

await provisionEmail(
[ProvisioningEmail(
toEmail: toEmail,
subject: subject,
content: '',
)],
sentLocation: PresentationMailbox.roleJunk,
);

await threadRobot.openMailbox();
await _expectMailboxWithNameHaveCountVisible(
appLocalizations.spamMailboxDisplayName,
);
await mailboxMenuRobot.longPressMailboxWithName(
appLocalizations.spamMailboxDisplayName,
);
await threadRobot.tapEmptySpamAfterLongPress();
await threadRobot.confirmEmptySpam();
_expectMailboxWithNameHaveCountInvisible(
appLocalizations.spamMailboxDisplayName,
);
await threadRobot.openMailbox();
await mailboxMenuRobot.openFolderByName(
appLocalizations.spamMailboxDisplayName,
);
await _expectSpamBannerInvisible();

await threadRobot.openMailbox();
await mailboxMenuRobot.longPressMailboxWithName(
appLocalizations.trashMailboxDisplayName,
);
await mailboxMenuRobot.tapRecoverDeletedMessages();
await mailboxMenuRobot.tapConfirmRecoverDeletedMessages();
await threadRobot.openMailbox();
await mailboxMenuRobot.openFolderByName(
appLocalizations.recoveredMailboxDisplayName,
);
await _expectEmailWithSubjectVisible(subject);
}

Future<void> _expectSpamBannerInvisible() async {
await $(#spam_banner_not_visible).waitUntilExists();
expect($(BannerDeleteAllSpamEmailsWidget).visible, false);
}

Future<void> _expectEmailWithSubjectVisible(String subject) async {
await expectViewVisible($(subject));
}

Future<void> _expectMailboxWithNameHaveCountVisible(String name) async {
await expectViewVisible(
$(TrailingMailboxItemWidget)
.which<TrailingMailboxItemWidget>((widget) {
return widget.mailboxNode.item.name?.name.toLowerCase() == name.toLowerCase();
})
);
}

void _expectMailboxWithNameHaveCountInvisible(String name) {
expect(
$(TrailingMailboxItemWidget)
.which<TrailingMailboxItemWidget>((widget) {
return widget.mailboxNode.item.name?.name.toLowerCase() == name.toLowerCase();
})
.visible,
false,
);
}
}
Loading
Loading