✨ Implement API update user #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lethemanh
force-pushed
the
feature/api-update-user
branch
from
94a23fe to
4cf17f2
Compare
lethemanh
force-pushed
the
feature/api-update-user
branch
5 times, most recently
from
d46d57c to
8d41180
Compare
ericlinagora
reviewed
Jan 8, 2025
| : instance.creation_date; | ||
| if (isChangeEmail) { | ||
| instance.username_canonical = ( | ||
| user.email.replace(/[^a-z0-9_-]/, "") || "" |
There was a problem hiding this comment.
I think this is copied from
, couldn't we have this logic in a single place ? in case the regex changes for example ?
lethemanh
force-pushed
the
feature/api-update-user
branch
2 times, most recently
from
e4e436a to
11b0519
Compare
lethemanh
force-pushed
the
feature/api-update-user
branch
from
11b0519 to
f0d83b1
Compare
MontaGhanmy
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.