Tw 2046 group name validation #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhaledNjim
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev,
hieutbui and
tddang-linagora
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2119 |
hoangdat
reviewed
Nov 4, 2024
hoangdat
reviewed
Nov 4, 2024
KhaledNjim
force-pushed
the
TW-2046_group_name_validation
branch
from
5153df0
to
8f9dd2e
Compare
KhaledNjim
changed the title
hoangdat
approved these changes
Nov 15, 2024
|
@nqhhdev please review this PR |
|
Pls update for edit group also 
|
nqhhdev
reviewed
Nov 18, 2024
nqhhdev
reviewed
Nov 18, 2024
nqhhdev
reviewed
Nov 18, 2024
KhaledNjim
force-pushed
the
TW-2046_group_name_validation
branch
from
8f9dd2e
to
c95ec5f
Compare
nqhhdev
reviewed
Nov 19, 2024
Co-authored-by: Huy Quang Nguyen <[email protected]>
|
IMO: Side effect, pls check it Screen.Recording.2024-11-19.at.15.37.48.mov |
i can reproduce this on older version, this happens when the name group is empty so the text displayed is just a placeholder returned by 2024-11-19.09-47-41.mp4
|
If empty chat I think no need to warning. Only warning after user edited fixed 2024-11-19.11-13-06.mp4 |
nqhhdev
reviewed
Nov 19, 2024
KhaledNjim
force-pushed
the
TW-2046_group_name_validation
branch
from
e1346a6
to
ff75dcc
Compare
hoangdat
approved these changes
Nov 20, 2024
hoangdat
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Root cause
Solution
Added validation for group name
Impact description
If this is not a bug, please explain how the changes affect the project
Resolved
2046.mp4