-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-2157: Fix can't mark a chat as unread #2158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqhhdev
requested review from
hoangdat,
dab246 and
tddang-linagora
as code owners
November 26, 2024 10:16
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2158 |
nqhhdev
force-pushed
the
TW-2157-cannot-mark-a-chat-as-unread
branch
from
November 26, 2024 10:54
243308b
to
4dd8751
Compare
hoangdat
reviewed
Nov 26, 2024
When the chat is muted the counter does not update 2157_mute_counter.mp4 |
Is this related to the ticket? |
hoangdat
reviewed
Nov 27, 2024
hoangdat
reviewed
Nov 27, 2024
hoangdat
reviewed
Nov 27, 2024
hoangdat
approved these changes
Nov 27, 2024
nqhhdev
force-pushed
the
TW-2157-cannot-mark-a-chat-as-unread
branch
from
November 27, 2024 09:38
6acbeca
to
1b5c16f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Root cause
Resolved
Screen.Recording.2024-11-26.at.17.12.24.mov