Skip to content

Commit

Permalink
Create test-legacy/ for android.test.legacy target
Browse files Browse the repository at this point in the history
The android.test.legacy (and legacy-android-test) target depends on
code from both test-base/ and test-runner/ and do not really belong
in either folder.

Having a separate folder will also provide a convenient place for
the artifacts needed to publish android.test.legacy to
maven.google.com.

Bug: 30188076
Test: make checkbuild

(cherry picked from commit 898e7de)

Change-Id: I0538281980a55178dd72e5fae16d817cd31aa104
  • Loading branch information
paulduffin committed Jan 31, 2018
1 parent 7c691c6 commit 3212bdb
Show file tree
Hide file tree
Showing 4 changed files with 76 additions and 43 deletions.
25 changes: 0 additions & 25 deletions test-base/Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -83,28 +83,3 @@ java_library_static {
"junit",
],
}

// Build the legacy-android-test library
// =====================================
// This contains the android.test classes that were in Android API level 25,
// including those from android.test.runner.
// Also contains the com.android.internal.util.Predicate[s] classes.
java_library_static {
name: "legacy-android-test",

srcs: [
"src/android/**/*.java",
"src/com/**/*.java",
],

static_libs: [
"android.test.runner-minus-junit",
"android.test.mock",
],

no_framework_libs: true,
libs: [
"framework",
"junit",
],
}
36 changes: 36 additions & 0 deletions test-legacy/Android.bp
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
//
// Copyright (C) 2018 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//

// Build the legacy-android-test library
// =====================================
// This contains the android.test classes that were in Android API level 25,
// including those from android.test.runner.
// Also contains the com.android.internal.util.Predicate[s] classes.
java_library_static {
name: "legacy-android-test",

static_libs: [
"android.test.base-minus-junit",
"android.test.runner-minus-junit",
"android.test.mock",
],

no_framework_libs: true,
libs: [
"framework",
"junit",
],
}
40 changes: 40 additions & 0 deletions test-legacy/Android.mk
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
#
# Copyright (C) 2018 The Android Open Source Project
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

LOCAL_PATH:= $(call my-dir)

# For unbundled build we'll use the prebuilt jar from prebuilts/sdk.
ifeq (,$(TARGET_BUILD_APPS)$(filter true,$(TARGET_BUILD_PDK)))

# Build the android.test.legacy library
# =====================================
include $(CLEAR_VARS)

LOCAL_MODULE := android.test.legacy

LOCAL_SDK_VERSION := current

LOCAL_JAVA_LIBRARIES := junit
LOCAL_STATIC_JAVA_LIBRARIES := \
android.test.base-minus-junit \
android.test.runner-minus-junit \

include $(BUILD_STATIC_JAVA_LIBRARY)

# Archive a copy of the classes.jar in SDK build.
$(call dist-for-goals,sdk win_sdk,$(full_classes_jar):android.test.legacy.jar)

endif # not TARGET_BUILD_APPS not TARGET_BUILD_PDK=true
18 changes: 0 additions & 18 deletions test-runner/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -117,23 +117,5 @@ update-android-test-runner-api: $(ANDROID_TEST_RUNNER_OUTPUT_API_FILE) | $(ACP)

endif # not TARGET_BUILD_APPS not TARGET_BUILD_PDK=true

# Build the android.test.legacy library
# =====================================
include $(CLEAR_VARS)

LOCAL_MODULE := android.test.legacy

LOCAL_SRC_FILES := $(call all-java-files-under, src/android)

LOCAL_SDK_VERSION := current

LOCAL_JAVA_LIBRARIES := android.test.mock.stubs junit
LOCAL_STATIC_JAVA_LIBRARIES := android.test.base-minus-junit

include $(BUILD_STATIC_JAVA_LIBRARY)

# Archive a copy of the classes.jar in SDK build.
$(call dist-for-goals,sdk win_sdk,$(full_classes_jar):android.test.legacy.jar)

# additionally, build unit tests in a separate .apk
include $(call all-makefiles-under,$(LOCAL_PATH))

0 comments on commit 3212bdb

Please sign in to comment.