build: updates project name and references. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oop - need to migrate to Yarn. |
hero-david
reviewed
Oct 9, 2024
hero-david
previously approved these changes
Oct 9, 2024
hero-david
reviewed
Oct 9, 2024
| @@ -19,6 +19,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "build": "ember build --environment=production", | |||
| "ci": "yarn install --ignore-engines --frozen-lockfile", | |||
There was a problem hiding this comment.
Is ignore engines still needed on node 14? And do we want to adjust the engines below?
There was a problem hiding this comment.
Great Q - For now I'm keeping it all similar across all projects, but will remove in future.
From memory there is something that causes an issue (requires newer node) ...
ember-cli-update/ember declare the engine preference, so I'm keeping it where ember believes the engines should be :)
Cheers man!
hero-david
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the goodies