Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template to consolidate pre-commit logic #24

Merged
merged 8 commits into from
Feb 13, 2024
Merged

Conversation

camposandro
Copy link
Collaborator

@camposandro camposandro commented Feb 12, 2024

Tests pre-commit as the sole runner of code quality checks.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a617e0a) 100.00% compared to head (3f22415) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           14        14           
=========================================
  Hits            14        14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Before [a617e0a] After [d653a69] Ratio Benchmark (Parameter)
1.74±0.5s 2.82±0.6s ~1.62 benchmarks.TimeSuite.time_keys
1.28±1s 1.99±1s ~1.56 benchmarks.TimeSuite.time_iterkeys
2.05±0.5s 2.34±0.5s ~1.14 benchmarks.TimeSuite.time_xrange
2.71±0.9s 2.42±0.5s ~0.89 benchmarks.TimeSuite.time_range
288 840 2.92 benchmarks.MemSuite.mem_list

Click here to view all benchmarks.

@camposandro camposandro marked this pull request as draft February 13, 2024 15:15
@camposandro camposandro marked this pull request as ready for review February 13, 2024 15:24
@camposandro camposandro marked this pull request as draft February 13, 2024 15:32
@camposandro camposandro marked this pull request as ready for review February 13, 2024 15:38
@camposandro camposandro force-pushed the update-template branch 2 times, most recently from 6bd499e to f6611d9 Compare February 13, 2024 15:44
@camposandro camposandro merged commit 5e29e36 into main Feb 13, 2024
9 checks passed
@camposandro camposandro deleted the update-template branch February 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant