Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundaries notebook #1

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Boundaries notebook #1

merged 1 commit into from
Jun 17, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Jun 17, 2024

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@hombit hombit requested a review from smcguire-cmu June 17, 2024 18:39
@hombit hombit force-pushed the boundaries-nb branch 2 times, most recently from 97d053d to 3928f6d Compare June 17, 2024 18:49
Co-authored-by: Sean McGuire <[email protected]>
Copy link
Contributor

@smcguire-cmu smcguire-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You could maybe disable the unit tests check until there are any, and I don't know how to get the notebook review plugin to work but that would be useful here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hombit
Copy link
Collaborator Author

hombit commented Jun 17, 2024

@smcguire-cmu I requested reviewNB access and let's add some tests later

@hombit hombit merged commit f32aa97 into main Jun 17, 2024
3 of 4 checks passed
@hombit hombit deleted the boundaries-nb branch June 17, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants