Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boundaries for first polar pixel above z=2/3 #5

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

smcguire-cmu
Copy link
Contributor

For checking whether to use polar or eq coordinates, we check if eq_z > 2/3 which isn't entirely accurate when looking at neighbor pixels. There are possible cases where this is true, but the polar values of k and kp are invalid. We previously cut off these values, but this causes some missing values in the first polar pixel above z=2/3 that borders the phi=0 line, as demonstrated in #2.

This updates the polar function to use the equatorial function when the values of k and kp are invalid for generating polar boundaries, which fixes the problem. This however does also cause overlap of edges in the pixels with 7 neighbors, so we may want to investigate changing the boundary values for those cases.

fixes #2

@smcguire-cmu smcguire-cmu requested a review from hombit June 21, 2024 22:24
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@smcguire-cmu smcguire-cmu merged commit 49f28b7 into main Jun 24, 2024
2 of 4 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/fix-boundaries branch June 24, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boundary equations are broken for the southeast polar meridian tile
2 participants