Fix boundaries for first polar pixel above z=2/3 #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For checking whether to use polar or eq coordinates, we check if
eq_z > 2/3
which isn't entirely accurate when looking at neighbor pixels. There are possible cases where this is true, but the polar values of k and kp are invalid. We previously cut off these values, but this causes some missing values in the first polar pixel above z=2/3 that borders the phi=0 line, as demonstrated in #2.This updates the polar function to use the equatorial function when the values of k and kp are invalid for generating polar boundaries, which fixes the problem. This however does also cause overlap of edges in the pixels with 7 neighbors, so we may want to investigate changing the boundary values for those cases.
fixes #2