Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run python project template #8

Merged
merged 5 commits into from
Aug 9, 2023
Merged

run python project template #8

merged 5 commits into from
Aug 9, 2023

Conversation

maxwest-uw
Copy link
Collaborator

run python project template on koffi

@maxwest-uw
Copy link
Collaborator Author

closes #5

@maxwest-uw maxwest-uw linked an issue Aug 8, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@b7fa7d7). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage        ?   73.44%           
=======================================
  Files           ?        3           
  Lines           ?      177           
  Branches        ?        0           
=======================================
  Hits            ?      130           
  Misses          ?       47           
  Partials        ?        0           

Copy link

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me. The only concern that was pointed out in the comment in the pyproject.toml file is around support for Python 3.7. Again, the template is known to work well for 3.8, 3.9 and 3.10. It likely will work just fine with 3.7 (since most of what you're getting out of it is CI and document building), but if you've got a 3.7 conda environment available to run all the unit tests in, that might be good.

Also, you'll notice that the majority of the CI workflows define a matrix of 3.8, 3.9, and 3.10. Again, if 3.7 is important to support, it would make sense to expand that list of python versions to include 3.7.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.prepare_project.sh Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@maxwest-uw maxwest-uw merged commit 2591ea3 into main Aug 9, 2023
9 checks passed
@maxwest-uw maxwest-uw deleted the ppt_onboarding branch August 9, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onboard onto lincc-frameworks python-project-template
2 participants