-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run python project template #8
Conversation
closes #5 |
Codecov Report
@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage ? 73.44%
=======================================
Files ? 3
Lines ? 177
Branches ? 0
=======================================
Hits ? 130
Misses ? 47
Partials ? 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great to me. The only concern that was pointed out in the comment in the pyproject.toml file is around support for Python 3.7. Again, the template is known to work well for 3.8, 3.9 and 3.10. It likely will work just fine with 3.7 (since most of what you're getting out of it is CI and document building), but if you've got a 3.7 conda environment available to run all the unit tests in, that might be good.
Also, you'll notice that the majority of the CI workflows define a matrix of 3.8, 3.9, and 3.10. Again, if 3.7 is important to support, it would make sense to expand that list of python versions to include 3.7.
run python project template on
koffi