Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove podcast.log errors on first run and fix xsltproc parsing for https feeds #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adam4235
Copy link

These changes fix 2 problems:

  • Remove the warnings that podcast.log can't be found when the script is run for the first time
  • When the RSS feed has an https link, the xsltproc command was giving an error. The example feeds are http but most feeds are https nowadays. This seems to be a known issue in xsltproc:
    https://gitlab.gnome.org/GNOME/libxslt/-/issues/28
    It seemed like maybe a benign problem in the script because, even without xsltproc installed, it still falls back on the use of sed to parse the xml document. Nevertheless, it can be processed with xsltproc by first downloading the xml document with wget, then calling xsltproc on it. According to the above linked issue, that seems to be the correct approach, so I changed bashpodder to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant