Fixes an issue where sending email to servers that don't require auth…

…entication would fail. Closes #425
lindegroup · Aug 12, 2015 · aaebb72 · aaebb72
1 parent 4a823c6
commit aaebb72
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/AutoPkgr/Models/Email & Notifications/LGEmailNotification.m b/AutoPkgr/Models/Email & Notifications/LGEmailNotification.m
@@ -47,7 +47,7 @@ + (BOOL)isEnabled
 
 + (BOOL)storesInfoInKeychain
 {
-    return YES;
+    return [[LGDefaults standardUserDefaults] SMTPAuthenticationEnabled];
 }
 
 + (NSString *)account

diff --git a/AutoPkgr/Views-Controllers-XIB/Tab Views/LGNotificationsViewController.m b/AutoPkgr/Views-Controllers-XIB/Tab Views/LGNotificationsViewController.m
@@ -187,7 +187,7 @@ - (void)savePassword:(void (^)(NSError *error))reply
     NSString *account = _smtpUsername.safe_stringValue;
     NSString *password = _smtpPassword.safe_stringValue;
 
-    if (account) {
+    if (account && [LGEmailNotification storesInfoInKeychain]) {
         [LGEmailNotification saveInfoToKeychain:password reply:^(NSError *error) {
             if (reply) {
                 reply(error);
@@ -206,6 +206,10 @@ - (void)savePassword:(void (^)(NSError *error))reply
                 }
             }
         }];
+    } else {
+        if(reply){
+            reply(nil);
+        }
     }
 }