Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nacos Support #5409
Add Nacos Support #5409
Changes from all commits
785b353
a76d4fc
4caabaf
3af6f6c
d4332aa
9530372
ffc64d7
68e1137
0f71869
46abd6d
adb40fc
0120fd7
12b2214
23d8913
0d0082d
a0d7895
a427074
625535a
ed1d5ba
f94cf66
c10ebc8
5fe5ba2
03150f2
88f6235
0a715cd
7476ede
4e29132
110ee22
0b988ba
8933fcd
94568bd
6231ee9
c2cd4e4
4f983a5
1d3f9c6
c773424
cccc61e
4ad84a5
e514772
edc84f2
44ac036
dab94b1
597d9f4
f6141d3
0d56428
2ffafe0
8c003bc
dc532a0
02c412c
dff6e08
ce4fe89
2841315
73a2e0f
83fdffa
268023f
e287a3e
d7c9dfc
a34068d
c690614
aae35fb
e8ce9c5
7f323be
73c1699
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be consistent with how the rnn is done for
nacosUri
andserviceName
? (Either rnn here, or just delegate the rnn toNacosClientBuilder
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about also adding a method that takes a token?
I think most users will:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minwoox
According to the Nacos documentation, there is no official support for generating access tokens directly. However, it can be added through a customized auth plugin. Since the specific requirements of the custom plugin are unpredictable, it seems preferable to allow users to customize decorator instead of provided LoginClient decorator.
Also, would it be beneficial to provide an implementation for Aliyun(Alibaba Cloud spec?) Auth?
https://nacos.io/en-us/docs/v2/plugin/auth-plugin.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know that requires additional plugin. 😓
Let's keep as is and implement the plugin later if there's a demand for that. 😉