Allow XdsEndpointGroup to disable health checking per Endpoint
#5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikhoon
reviewed
Sep 13, 2024
.../java/com/linecorp/armeria/internal/client/endpoint/healthcheck/StaticHttpHealthChecker.java
Outdated
Show resolved
Hide resolved
| ClientRequestContext.of(HttpRequest.of(HttpMethod.GET, "/")); | ||
|
|
||
| private StaticHttpHealthChecker(HealthCheckerContext ctx, double healthy) { | ||
| ctx.updateHealth(healthy, NOOP_CTX, null, null); |
There was a problem hiding this comment.
How about specifying null instead of a mock context? I think that would be more clear.
There was a problem hiding this comment.
Modified the contract of updateHealth to accept a @Nullable
jrhee17
force-pushed
the
feature/xds-disable-hc
branch
from
9aa9249
to
154ea0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
While working on documentation, I realized that
disable_active_health_checkis not supported.ref: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/endpoint/v3/endpoint_components.proto#config-endpoint-v3-endpoint-healthcheckconfig
This can be useful when users would like to force certain endpoints to be healthy without health checking.
Modifications:
HttpHealthCheckertoDefaultHttpHealthCheckerHttpHealthCheckerinterfaceStaticHttpHealthCheckerwhich sets the health status immediatelyHealthCheckConfig#getDisableActiveHealthCheckand decide whether to return aStaticHttpHealthCheckerResult:
disable_active_health_checkis now supported