Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GraalVM native image metadata #5946

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Update GraalVM native image metadata #5946

merged 2 commits into from
Nov 7, 2024

Conversation

trustin
Copy link
Member

@trustin trustin commented Oct 16, 2024 •
edited
Loading

Motivation:

GraalVM native image tool fails to generate a working binary since
Armeria 1.30.0, due to its outdated metadata. Special thanks to @Dogacel
who reported this issue.

Modifications:

  • Updated the GraalVM native image metadata.
  • Removed the redundent ../../ from the resource lookup in ThriftMetadatAccess.

Result:

Armeria is again compatible with GraalVM native image tool.

@trustin
Update GraalVM native image metadata
94b5513 
Motivation:

GraalVM native image tool fails to generate a working binary since
Armeria 1.30.0, due to its outdated metadata. Special thanks to @Dogacel
who reported this issue.

Modifications:

Update the GraalVM native image metadata.

Result:

Armeria is again compatible with GraalVM native image tool.
@trustin trustin added the defect label Oct 16, 2024
@trustin trustin added this to the 1.31.0 milestone Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔍 Build Scan® (commit: 94b5513)

Job name Status Build Scan®
build-ubicloud-standard-8-jdk-8 ✅ https://ge.armeria.dev/s/ndgtrqetalt4s
build-ubicloud-standard-8-jdk-21-snapshot-blockhound ✅ https://ge.armeria.dev/s/mntxx5twpqpie
build-ubicloud-standard-8-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/tprpzvbz6fet6
build-ubicloud-standard-8-jdk-17-min-java-11 ❌ (failure) https://ge.armeria.dev/s/pr5fhz3gzf3ak
build-ubicloud-standard-8-jdk-17-leak ✅ https://ge.armeria.dev/s/olcacbufye2eu
build-ubicloud-standard-8-jdk-11 ✅ https://ge.armeria.dev/s/lnyhmps7wrofi
build-macos-12-jdk-21 ❌ (failure) https://ge.armeria.dev/s/ebklgxvlvabvy

ikhoon
ikhoon approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jrhee17
jrhee17 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

minwoox
minwoox approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@jrhee17 jrhee17 merged commit 2ea65f5 into main Nov 7, 2024
25 checks passed
@jrhee17 jrhee17 deleted the update_graalvm_metadata branch November 7, 2024 02:13
@imasahiro
Copy link
Member

just curious, do we have a CI with GraalVM? (seems not configured yet? https://github.com/line/armeria/blob/main/.github/workflows/actions_build.yml )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minwoox minwoox minwoox approved these changes

@jrhee17 jrhee17 jrhee17 approved these changes

@ikhoon ikhoon ikhoon approved these changes

Assignees
No one assigned
Labels
defect
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
5 participants
@trustin @imasahiro @ikhoon @jrhee17 @minwoox