-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies for 1.31.0 #5967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
Optional)Would you also upgrade Gradle dependency? That could be a preliminary step before upgrading Java version to 23.
@@ -173,7 +173,7 @@ final class ScalaPbRequestConverterFunction private (jsonParser: Parser, resultT | |||
*/ | |||
private def jsonToScalaPbMessage(expectedResultType: Class[_], json: String): Any with Serializable = { | |||
val messageType = extractGeneratedMessageType(expectedResultType) | |||
val message: GeneratedMessage = jsonParser.fromJsonString(json)(getCompanion(messageType)) | |||
val message: GeneratedMessage = jsonParser.fromJsonString(json)(using getCompanion(messageType)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍
Dependencies
Dev dependencies
Additional changes
logback15
which runs tests in thelogback14
module withlogback15
to ensure compatibility.DropwizardExtensionsSupport
isn't compatible with recent JUnit versions following the removal ofReflectionUtils#makeAccessible(AccessibleObject)
. Thebefore
method is called manually.using
keywordAbstractProcessor
has added aearlyHints
method which needs to be implemented