Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to access for a member to the meta repository. #901

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

minwoox
Copy link
Contributor

@minwoox minwoox commented Nov 30, 2023

Motivation:
Despite having the necessary permissions after #898, members were unable to access the meta repository.

Modifications:

  • Implemented a fix to ensure that members can access the meta repository as intended.

Result:

  • Members with appropriate permissions can now successfully access the meta repository.

Motivation:
Despite having the necessary permissions after line#898, members were unable to access the meta repository.

Modifications:
- Implemented a fix to ensure that members can access the meta repository as intended.

Result:
- Members with appropriate permissions can now successfully access the meta repository.
@minwoox minwoox added the defect label Nov 30, 2023
@minwoox minwoox added this to the 0.63.3 milestone Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0afa010) 66.11% compared to head (28877bf) 66.19%.

Files Patch % Lines
...internal/api/auth/RequiresPermissionDecorator.java 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #901      +/-   ##
============================================
+ Coverage     66.11%   66.19%   +0.08%     
  Complexity     3405     3405              
============================================
  Files           363      363              
  Lines         14121    14109      -12     
  Branches       1511     1509       -2     
============================================
+ Hits           9336     9340       +4     
+ Misses         3921     3902      -19     
- Partials        864      867       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @minwoox!

Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@minwoox minwoox merged commit 2b07420 into line:main Dec 8, 2023
9 of 10 checks passed
@minwoox minwoox deleted the fix_member_access_meta branch December 8, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants