Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a parameter for setting initialWebAuthenticationMethod #173

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Add a parameter for setting initialWebAuthenticationMethod #173

merged 2 commits into from
Dec 27, 2024

Conversation

YkSix
Copy link
Contributor

@YkSix YkSix commented Dec 26, 2024 •
edited
Loading

Using this setting, users can specify which auth method (email&password or QR code) should be preferred as the first screen when performing web login.

Sample usage:

val loginAuthParam = LineAuthenticationParams.Builder()
    .initialWebAuthenticationMethod( ... )
    .build()

val intent = LineLoginApi.getLoginIntent(
    context,
    channelId,
    loginAuthParam
)

By default, email is used to keep the current behavior unchanged.

Corresponding PR in iOS side:

YkSix added 2 commits December 26, 2024 10:17
@YkSix
feature: implement LineAuthenticationParams # initialWebAuthenticatio…
d316ce2 
…nMethod

Specifies the initial web authentication method to be used when starting the login process.
@YkSix
dev: add CheckBox in sample app to specify the initial web authentica…
4e24c10 
…tion method

WebAuthenticationMethod
- email
- qrCode
@YkSix YkSix requested a review from tsairene December 26, 2024 03:50
tsairene
tsairene approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@tsairene tsairene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YkSix YkSix merged commit 1b28843 into line:master Dec 27, 2024
3 checks passed
@YkSix YkSix deleted the feature/initial-qr-screen branch December 27, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsairene tsairene tsairene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YkSix @tsairene