Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix! Enhancements in Deletion Functionality #201

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

jandsonrj
Copy link
Member

@jandsonrj jandsonrj commented Sep 19, 2023

  1. Users with common privileges can now only delete their own records, while administrators retain the ability to delete any record. The DeleteIcon is intelligently disabled for products owned by other users, while it remains active for administrators.

  2. Was added an informative hover message to the DeleteIcon. Now, when you hover your mouse over the icon, you'll receive context-aware feedback:

  • If you're the owner of the record, you'll receive a positive message.
  • If the record doesn't belong to you, you'll receive a negative message.

Here is a short video demonstrating the features of this update.

… uploaded by another user has been addressed
@jandsonrj jandsonrj added bug Something isn't working enhancement Feature improvement labels Sep 19, 2023
@jandsonrj jandsonrj linked an issue Sep 19, 2023 that may be closed by this pull request
…p-up will appear with the message that it is not possible.
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #201 (7cc707c) into main (990080a) will increase coverage by 0.26%.
The diff coverage is 100.00%.

❗ Current head 7cc707c differs from pull request most recent head 4b49abb. Consider uploading reports for the commit 4b49abb to get more accurate results

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   72.50%   72.77%   +0.26%     
==========================================
  Files          24       24              
  Lines         811      819       +8     
==========================================
+ Hits          588      596       +8     
  Misses        223      223              
Files Coverage Δ
backend/core/models/product.py 100.00% <100.00%> (ø)
backend/core/serializers/product.py 100.00% <100.00%> (ø)
backend/core/views/product.py 47.29% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jandsonrj jandsonrj changed the title Don't close this PR for now, please! Fix! Now, a common user will only be able to delete their record, and administrators will be able to delete any record. Oct 6, 2023
@jandsonrj jandsonrj changed the title Fix! Now, a common user will only be able to delete their record, and administrators will be able to delete any record. Fix! Enhancements in Deletion Functionality Oct 6, 2023
@jandsonrj jandsonrj added the new feature New feature or request label Oct 6, 2023
Copy link
Member

@gschwend gschwend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with both admin and regular users.

@jandsonrj jandsonrj merged commit 80fa8d3 into main Oct 6, 2023
3 checks passed
@jandsonrj jandsonrj deleted the 192-remove-another-users-product branch October 6, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Feature improvement new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to remove another user's product.
3 participants