-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Pipelines page layout #203
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 72.50% 72.50%
=======================================
Files 24 24
Lines 811 811
=======================================
Hits 588 588
Misses 223 223 ☔ View full report in Codecov by Sentry. |
… from the general background color.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on localhost
frontend/styles/pages/banner.js
Outdated
@@ -0,0 +1,51 @@ | |||
import { makeStyles } from '@mui/styles' | |||
|
|||
const useStyles = makeStyles(theme => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jandsonrj é melhor substitui o makeStyle pelo sx ou styled componente a versão nova do material está abandonando o makestyle.
Sugiro o uso sx ao inves de ter um arquivo com todos os css coloca o que seria classe direto no atributo sx do componente.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is out of use, I just forgot to remove it. Now, it has been removed!
frontend/pages/specz_catalogs.js
Outdated
|
||
function SpeczCatalogs() { | ||
return ( | ||
<div style={{ textAlign: 'center' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Como estamos usando material ui, ao inves de criar uma div com style pode usar o Box com sx no final é a mesma coisa, mas vc vai estar usando a sintaxe do material ui
caso precisemos alterar alguma coisa no futuro todos os componentes vão estar uniformes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I made the suggested changes.
I put 'div' because it is a temporary screen, as I am already developing the main screen. Thank you for the tips.
I need you to close this PR urgently so that I can continue with the new screens from this update