Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pipelines page layout #203

Merged
merged 9 commits into from
Dec 1, 2023
Merged

Conversation

jandsonrj
Copy link
Member

@jandsonrj jandsonrj commented Oct 3, 2023

I need you to close this PR urgently so that I can continue with the new screens from this update

@jandsonrj jandsonrj added enhancement Feature improvement new feature New feature or request labels Oct 3, 2023
@jandsonrj jandsonrj linked an issue Oct 3, 2023 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (990080a) 72.50% compared to head (7ab2180) 72.50%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   72.50%   72.50%           
=======================================
  Files          24       24           
  Lines         811      811           
=======================================
  Hits          588      588           
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gschwend gschwend marked this pull request as draft October 6, 2023 22:22
@gschwend gschwend self-requested a review November 28, 2023 14:30
Copy link
Member

@gschwend gschwend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on localhost

@@ -0,0 +1,51 @@
import { makeStyles } from '@mui/styles'

const useStyles = makeStyles(theme => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jandsonrj é melhor substitui o makeStyle pelo sx ou styled componente a versão nova do material está abandonando o makestyle.
Sugiro o uso sx ao inves de ter um arquivo com todos os css coloca o que seria classe direto no atributo sx do componente.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is out of use, I just forgot to remove it. Now, it has been removed!


function SpeczCatalogs() {
return (
<div style={{ textAlign: 'center' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Como estamos usando material ui, ao inves de criar uma div com style pode usar o Box com sx no final é a mesma coisa, mas vc vai estar usando a sintaxe do material ui
caso precisemos alterar alguma coisa no futuro todos os componentes vão estar uniformes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I made the suggested changes.
I put 'div' because it is a temporary screen, as I am already developing the main screen. Thank you for the tips.

@gschwend gschwend marked this pull request as ready for review November 29, 2023 18:24
@jandsonrj jandsonrj merged commit f36b18c into main Dec 1, 2023
5 checks passed
@jandsonrj jandsonrj deleted the 184-implement-pipelines-page-layout branch December 1, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvement new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Pipelines page layout
3 participants