Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #212 - The new 'STATUS' column was implemented in Data Products #217

Closed
wants to merge 1 commit into from

Conversation

jandsonrj
Copy link
Member

News in Data Products:

Added "Status" column to the dataset in Data Products to reflect the current state of each product. The "Status" column now displays crucial information about the product's progress. The possible values and their meanings are as follows:

  • 0: 'Registering': Indicates that the product is in the registration process.
  • 1: 'Published': Signals that the product was published successfully.
  • 9: 'Failed': Indicates that a failure occurred during the process.

image

@jandsonrj jandsonrj added the enhancement Feature improvement label Dec 8, 2023
@jandsonrj jandsonrj linked an issue Dec 8, 2023 that may be closed by this pull request
Copy link
Member

@gschwend gschwend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jandsonrj I tested it on localhost and the STATUS column is ok on both pages (official and user-generated products). One question: I did an upload and monitored the product list in real time. Isn't it expected to show the product on the list while it is being uploaded with a status like "registering"?

@glaubervila
Copy link
Contributor

glaubervila commented Dec 12, 2023

@jandsonrj I tested it on localhost and the STATUS column is ok on both pages (official and user-generated products). One question: I did an upload and monitored the product list in real time. Isn't it expected to show the product on the list while it is being uploaded with a status like "registering"?

Hi @gschwend , The previous rule was to only display products as a completed registration process. With this rule in mind, you wouldn't need the status column.

As it was changed to have the status column in the list, it will be necessary to change the rule so that all products regardless of status are displayed in the list.

Initially, the status field is only for controlling the registration form, the product only has 2 statuses pending or completed. The failures are displayed to the user at the time of registration and he is unable to complete it, so a failed registration is not possible today.

Changing this impacts the entire registration flow, which can be confusing for the user.
If other statuses are necessary, it would be better to consider the current column as the registration-only status, "in progress" or "complete"

@gschwend
Copy link
Member

@glaubervila the status became necessary now that we are implementing the possibility of creating data products by the pz server's pipelines, which can take hours. I supposed the same could be applied to products on ongoing uploads, but just for consistency. Actually, this is not critical and it can wait to be implemented in future versions. Please approve this PR as it is. I will add new issues to cover the subject of products "in preparation" or "under construction" when necessary.

@glaubervila
Copy link
Contributor

@glaubervila the status became necessary now that we are implementing the possibility of creating data products by the pz server's pipelines, which can take hours. I supposed the same could be applied to products on ongoing uploads, but just for consistency. Actually, this is not critical and it can wait to be implemented in future versions. Please approve this PR as it is. I will add new issues to cover the subject of products "in preparation" or "under construction" when necessary.

@gschwend this implementation will cause problems, I suggest renaming this current status field to something like register_status and creating a new field to manage the statuses that will be updated by the pipeline

@gschwend gschwend marked this pull request as draft December 12, 2023 19:26
@gschwend
Copy link
Member

gschwend commented Dec 12, 2023

@crisingulani @jandsonrj just to let you know:
chatting with @glaubervila we identified that this PR will worsen the current implementation, therefore it is better to take a step back and differentiate the status depending on the origin of the data product (i.e., upload or pipeline).
I am converting this PR to draft PR and adding a couple of additional tasks to #212. It might require small changes in the back-end.

@gschwend gschwend closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

column product status
3 participants