Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render layers #68

Merged
merged 9 commits into from
Jul 27, 2024
Merged

Conversation

ChristopherBiscardi
Copy link
Contributor

This is a rebased version of #49 which looks like it only needed merge conflicts resolved

@ChristopherBiscardi ChristopherBiscardi changed the title Use the first camera on RenderLayer 0 (rebased) support multiple cameras (rebased) Jul 24, 2024
@simbleau
Copy link
Member

Hey Chris! Thanks for the assist. I'll take a look shortly.

@simbleau
Copy link
Member

This almost works. I'll probably commit to this branch if that's ok with you, Chris. This is a good base.
image

@ChristopherBiscardi
Copy link
Contributor Author

@simbleau totally cool with me!

@simbleau simbleau mentioned this pull request Jul 25, 2024
@simbleau
Copy link
Member

This is stickier than I thought. See #58 for additional discussion.

Nonetheless, I'm making progress.

@simbleau simbleau changed the title support multiple cameras (rebased) Fix render layers Jul 27, 2024
@simbleau
Copy link
Member

simbleau commented Jul 27, 2024

@ChristopherBiscardi

Render layers have been obeyed, there's a new render_layers example that uses Gizmos and render layers as well. Feel free to bend it to your will and let me know if behavior is as you expect.

In the example there are 2 cameras,

  • Camera A renders with a camera order -1 and has a blue rect on Layer 2.
  • Camera B has two vello animations with a camera order 1.
  • Gizmos are rendered over everything else.
image

@simbleau simbleau added this pull request to the merge queue Jul 27, 2024
Merged via the queue into linebender:main with commit ad322d2 Jul 27, 2024
3 checks passed
@ChristopherBiscardi
Copy link
Contributor Author

awesome! thank you! I'll let you know how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants