Add the ACES2065-1 color space #124
Conversation
| /// [smpte]: https://pub.smpte.org/doc/st2065-1/20200909-pub/st2065-1-2021.pdf | ||
| /// [aceswp]: https://docs.acescentral.com/tb/white-point | ||
| #[derive(Clone, Copy, Debug)] | ||
| pub struct Aces2065_1; |
There was a problem hiding this comment.
The underscore in the name is "correct," but also a bit awkward, as it's just a single digit trailing.
| for (srgb, aces2065_1) in [ | ||
| ([0.6, 0.5, 0.4], [0.245_59, 0.215_57, 0.145_18]), | ||
| ([0.0, 0.5, 1.0], [0.259_35, 0.270_89, 0.894_79]), | ||
| ] { |
There was a problem hiding this comment.
These cases were generated with ColorAide.
| @@ -48,6 +48,8 @@ pub enum ColorSpaceTag { | |||
| ProphotoRgb = 10, | |||
| /// The [`Rec2020`] color space. | |||
| Rec2020 = 11, | |||
| /// The [`Aces2065_1`] color space. | |||
| Aces2065_1 = 15, | |||
| /// The [`AcesCg`] color space. | |||
| AcesCg = 12, | |||
| /// The [`XyzD50`] color space. | |||
There was a problem hiding this comment.
How do we want to keep this sorted? Renumbering may be breaking. If we don't renumber, I think I favor keeping related color spaces grouped together.
There was a problem hiding this comment.
I'm okay with what you did, but I think probably would be good to put a comment somewhere in there about it. I don't think re-numbering is good except (maybe) at breaking changes.
There was a problem hiding this comment.
I tend to agree that re-numbering in a patch release would be bad. But I also think that we should renumber these when we next make a breaking change. If people are storing color spaces in a file, then I'd like to encourage them to make their own ordering.
There was a problem hiding this comment.
I've noted the numbering may change, so users do not start relying on the numbering for archival.
If we do decide at some point never to renumber, it's easy enough to make the guarantee then.
| @@ -15,6 +15,10 @@ You can find its changes [documented below](#022-2025-01-03). | |||
|
|
|||
| This release has an [MSRV][] of 1.82. | |||
|
|
|||
| ### Added | |||
|
|
|||
| * Support for the ACES2065-1 color space. ([#124][] by [@tomcur][]) | |||
There was a problem hiding this comment.
Need link below. Since I too love to forget them...
There was a problem hiding this comment.
I use Markdownlint to detect these, which generally works well (this is why the trailing [] are there, incidentally)
There was a problem hiding this comment.
My settings are:
"markdownlint.config": {
"no-emphasis-as-heading": false,
"ul-indent": false,
"no-inline-html": false,
"first-line-h1": false,
"no-duplicate-heading": false
},
|
Given the reaction by @raphlinus in the Zulip thread, I think this can land today! |
This color space doesn't need anything fancy and [probably is useful](https://xi.zulipchat.com/#narrow/channel/466849-color/topic/Support.20for.20ACES2065-1.2FAP0).
This color space doesn't need anything fancy and probably is useful.