Add Lab and Lch color spaces #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the colorspaces and associated logic. Also fix `map_lightness` implementations, I had forgotten that these don't have the same bounds as Oklab and Oklch.
waywardmonkeys
approved these changes
Nov 9, 2024
Mostly doc fixes.
waywardmonkeys
approved these changes
Nov 9, 2024
color/src/color.rs
Outdated
| @@ -202,14 +202,17 @@ impl<CS: ColorSpace> OpaqueColor<CS> { | |||
| /// | |||
| /// In a color space that naturally has a lightness component, map that value. | |||
| /// Otherwise, do the mapping in Oklab. The lightness range is normalized so | |||
| /// that 1.0 is white. | |||
| /// that 1.0 is white. That is the normal range for Oklab but differs from the | |||
| /// range in Lab, Lch, and HSL. | |||
There was a problem hiding this comment.
Sorry, but can these be links?
color/src/color.rs
Outdated
| @@ -298,14 +301,17 @@ impl<CS: ColorSpace> AlphaColor<CS> { | |||
| /// | |||
| /// In a color space that naturally has a lightness component, map that value. | |||
| /// Otherwise, do the mapping in Oklab. The lightness range is normalized so | |||
| /// that 1.0 is white. | |||
| /// that 1.0 is white. That is the normal range for Oklab but differs from the | |||
| /// range in Lab, Lch, and HSL. | |||
Since we don't have the HSL color space yet, I linked the relevant spec section. That's a minor cleanup for when we do add HSL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the colorspaces and associated logic.
Also fix
map_lightnessimplementations, I had forgotten that these don't have the same bounds as Oklab and Oklch.