Cleanups and renames #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to feedback on #3.
color/src/tagged.rs
Outdated
| XyzD65, | ||
| }; | ||
|
|
||
| /// The colorspace tag for tagged colors. | ||
| /// The colo rspace tag for tagged colors. |
There was a problem hiding this comment.
Space in wrong place!
DJMcNab
approved these changes
Nov 5, 2024
color/src/colorspace.rs
Outdated
| /// | ||
| /// Calculations in linear colorspaces can sometimes be simplified, | ||
| /// Calculations in linear colors paces can sometimes be simplified, |
There was a problem hiding this comment.
You're certainly putting the reviewers through our paces with this one.
| /// The tag corresponding to this colorspace, if a matching tag exists. | ||
| const CS_TAG: Option<ColorspaceTag> = None; | ||
| /// The tag corresponding to this color space, if a matching tag exists. | ||
| const TAG: Option<ColorSpaceTag> = None; |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
Also add #[must_use]. (`AlphaColor::difference` was simplified in #7).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to feedback on #3.
One comment that was not addressed was direct conversion between color spaces, as opposed to always going through linear rgb.