-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report for snapshot testing (diff included) #185
base: main
Are you sure you want to change the base?
Conversation
Some thoughts:
|
|
521d855
to
88929a8
Compare
I have added |
Thank you! The new in-repository version looks really good. Would you mind opening a thread about image_diff_review in #linebender? I think that's probably the next steps here. The questions are:
My preference would be to nerd-snipe someone into writing a Xilem application, as that would have the greatest upside for us - it would allow us to validate the development of Xilem. But I do think the html version is still useful to have; I'll review again next week when we see what the outcome of that thread is. From a quick scan, it looks good. One thing I did notice is that this seems to add a dependency on |
Thanks. I will start the thread. Many dependencies comes from the "image" crate with default features, by default it is able to load various formats. |
Dependency tree was stripped down. |
I did some refactoring of xtask CLI and added detection of dead snapshots. |
The xtask is now migrated to Kompari. |
This PR adds reporting to tests.
Originally I wanted to integrate reporting directly into the testing framework,
but at the end, I have create a separate tool https://github.com/spirali/image_diff_review
and put a simple script into the Parley repository.
The main reasons are:
Installation:
cargo install image_diff_review
Usage:
If one or more tests fails, you may run
/parley/tests/make_report.sh
that creates areport.html
filethat looks like this: