Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. inline box layout fixes #207

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

nicoburns
Copy link
Contributor

@nicoburns nicoburns commented Dec 6, 2024

See individual commits:

  • Fix whitespace collapsing when first item in a span is an inline box
    • <p><img src="..." /> label</p> should have a space between the image and "label".
  • Fix wrapping when layout contains only inline boxes
  • Test case for layout with only inline boxes
  • Prevent inline boxes from being duplicated when the line ends with an inline box.
  • Fix trailing whitespace computation:
    • If the last item on a line is an inline box, then it does not have any trailing whitespace.

@nicoburns nicoburns changed the title Misc. layout fixes Misc. inline box layout fixes Dec 6, 2024
@nicoburns nicoburns force-pushed the wc-first-item-inline-box branch 3 times, most recently from 6d8f0fb to 3ff5ba0 Compare December 6, 2024 21:18
@nicoburns nicoburns requested review from dfrg, xorgy and DJMcNab December 6, 2024 21:23
@nicoburns nicoburns force-pushed the wc-first-item-inline-box branch from 4ef147d to f07e4bc Compare December 7, 2024 03:26
@DJMcNab
Copy link
Member

DJMcNab commented Dec 9, 2024

Is there something specific in here you want me to review - just want to check why my review has been requested?
Unfortunately, this code isn't something I have any real understanding of

@nicoburns
Copy link
Contributor Author

Is there something specific in here you want me to review - just want to check why my review has been requested? Unfortunately, this code isn't something I have any real understanding of

Not really. Just keen to get it reviewed so we can get it merged (I think this is the only thing blocking a 0.3 release). I thought you had reviewed similar PRs recently, and might be up for reviewing this one. But no worries if not!

@nicoburns nicoburns force-pushed the wc-first-item-inline-box branch from f07e4bc to f9d8355 Compare December 16, 2024 17:31
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can only impact users of the tree style builder and/or inline boxes, both of which I think you're the only user of currently. So since this is unlikely to be swiftly reviewed otherwise, I'm happy to unblock.

Ideally, this would get a review from someone with domain knowledge at some point...

@nicoburns nicoburns added this pull request to the merge queue Dec 18, 2024
Merged via the queue into linebender:main with commit 93dccce Dec 18, 2024
20 checks passed
@nicoburns nicoburns deleted the wc-first-item-inline-box branch December 18, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants