-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc. inline box layout fixes #207
Misc. inline box layout fixes #207
Conversation
6d8f0fb
to
3ff5ba0
Compare
4ef147d
to
f07e4bc
Compare
Is there something specific in here you want me to review - just want to check why my review has been requested? |
Not really. Just keen to get it reviewed so we can get it merged (I think this is the only thing blocking a 0.3 release). I thought you had reviewed similar PRs recently, and might be up for reviewing this one. But no worries if not! |
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
A line does not have trailing whitespace if the last item is an inline box.
f07e4bc
to
f9d8355
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can only impact users of the tree style builder and/or inline boxes, both of which I think you're the only user of currently. So since this is unlikely to be swiftly reviewed otherwise, I'm happy to unblock.
Ideally, this would get a review from someone with domain knowledge at some point...
See individual commits:
<p><img src="..." /> label</p>
should have a space between the image and "label".