fontique: Move creation of attributes from fontconfig #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
force-pushed
the
move-fontconfig-helpers
branch
from
9eff2ea to
d2f5b0f
Compare
This exposes `from_fontconfig` functions on `FontStretch`, `FontStyle`, and `FontWeight` rather than only defining them locally within the fontconfig code. This is in preparation for a change similar to linebender#209 where these types and others get pulled into a shared vocabulary crate and this sort of constructor helper would be useful to others.
waywardmonkeys
force-pushed
the
move-fontconfig-helpers
branch
from
d2f5b0f to
2a1bb86
Compare
|
Is there any use-case for these outside of Linux? They were previously only compiled on Linux. |
|
Partly that the effort to restrict them is currently not correct (since this would be useful on FreeBSD and others as well). They're only 3 small functions, so not a big deal. I wish we had better platform control over features. |
DJMcNab
approved these changes
Dec 9, 2024
Co-authored-by: Daniel McNab <[email protected]>
Co-authored-by: Daniel McNab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes
from_fontconfigfunctions onFontStretch,FontStyle, andFontWeightrather than only defining them locally within the fontconfig code.This is in preparation for a change similar to #209 where these types and others get pulled into a shared vocabulary crate and this sort of constructor helper would be useful to others.