Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This associated a user-specified ID with each style span in a
TreeBuilder
, which can then be retrieved from aCluster
after layout (and notably from aCluster
created usingCluster::from_point
).This enables hit-testing of inline spans (for click and hover behaviour).
The current behaviour of
Cluster::from_point
isn't ideal for this application: it will try to find the "nearest" cluster even if the cursor isn't exactly above one (which makes sense for placing a caret but not for hover/click). But it's "good enough" for now, and I think we can add a new function for that in a followup.Rendered using Parley + Blitz:
Screen.Recording.2024-12-17.at.07.51.41.mov