-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to git Vello, new releases of Color, Peniko #231
Update to git Vello, new releases of Color, Peniko #231
Conversation
d42ad6c
to
f6ad184
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see the need to split them out, as the actual changes are trivial (oh I see, it's allow attributes; I'd be happy to just allow that temporarily). I am however a little hesitant to actually merge this upgrade here; I think we should treat it as experiment.
In my mind, the git dependency on Color in Peniko/Vello is useful, because that's needed for developing Vello further. But this upgrade is largely peripheral, only in proving out the upgrade.
That is, my gut reaction is to make this into a draft PR for now (and have a corresponding draft PR to Xilem)
If you need the corresponding PR in Xilem, let me know and I'll make it today.
I have a corresponding branch in xilem already, just not pushed yet, I think. |
f6ad184
to
4bc9544
Compare
9c895cc
to
352d156
Compare
@DJMcNab Now that Color and Peniko are released, I'd like to get this in here so that we're getting closer to what we need for the upcoming Parley release (and once this is in here, I'll do the same for Xilem). |
The PR title might need to change. |
Ah, I'd changed the title in the commit but not in the PR. |
@DJMcNab Updated! |
No description provided.