Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to git Vello, new releases of Color, Peniko #231

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

@waywardmonkeys waywardmonkeys force-pushed the update-peniko-color branch 3 times, most recently from d42ad6c to f6ad184 Compare December 16, 2024 22:51
@waywardmonkeys
Copy link
Contributor Author

@DJMcNab I think someone should separate the MSRV update out of this and handle the noisy changes from that separately ... I've started with cleaning up some stuff as separate PRs (#232, #233).

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see the need to split them out, as the actual changes are trivial (oh I see, it's allow attributes; I'd be happy to just allow that temporarily). I am however a little hesitant to actually merge this upgrade here; I think we should treat it as experiment.

In my mind, the git dependency on Color in Peniko/Vello is useful, because that's needed for developing Vello further. But this upgrade is largely peripheral, only in proving out the upgrade.

That is, my gut reaction is to make this into a draft PR for now (and have a corresponding draft PR to Xilem)

If you need the corresponding PR in Xilem, let me know and I'll make it today.

@waywardmonkeys
Copy link
Contributor Author

I have a corresponding branch in xilem already, just not pushed yet, I think.

@waywardmonkeys waywardmonkeys marked this pull request as draft December 18, 2024 04:49
@waywardmonkeys waywardmonkeys marked this pull request as ready for review December 18, 2024 17:51
@waywardmonkeys
Copy link
Contributor Author

@DJMcNab Now that Color and Peniko are released, I'd like to get this in here so that we're getting closer to what we need for the upcoming Parley release (and once this is in here, I'll do the same for Xilem).

@DJMcNab
Copy link
Member

DJMcNab commented Dec 18, 2024

The PR title might need to change.

@waywardmonkeys
Copy link
Contributor Author

Ah, I'd changed the title in the commit but not in the PR.

@waywardmonkeys waywardmonkeys changed the title Update to git Color, Peniko, Vello Update to git Vello, new releases of Color, Peniko Dec 18, 2024
@waywardmonkeys
Copy link
Contributor Author

@DJMcNab Updated!

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Dec 18, 2024
Merged via the queue into linebender:main with commit 16b6251 Dec 18, 2024
20 checks passed
@waywardmonkeys waywardmonkeys deleted the update-peniko-color branch December 18, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants