Store snapshots using git lfs
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... seems |
|
Interesting, GitHub doesn't show the images in the "Files changed" tab anymore, but if you click "View file", like this, it does show them. |
|
Daniel and I think that's because the file moved from the repository to LFS, which GitHub's UI might not know how to deal with. In Vello, the LFS-stored files do have functioning diffs in GitHub's UI. (For example here, scroll to |
|
Ah, yeah, it might not be able to show a diff between a non-LFS and LFS file, but that's only a problem for this specific PR. |
|
CI is stuck again. edit: seems it actually was GitHub's YAML parser having trouble parsing |
Message bump for CI. Co-authored-by: Daniel McNab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on Vello's LFS setup, including the mechanism that allows easily disabling the tests that rely on LFS, just in case bandwidth runs out.