lints: Enable warn(unused_qualifications)
#53
Conversation
waywardmonkeys
force-pushed
the
fix-unused-qualifications
branch
from
3fabe01 to
9edcfa5
Compare
| node: Node, | ||
| config_file_path: impl AsRef<std::path::Path>, | ||
| ) -> Option<std::path::PathBuf> { | ||
| fn resolve_dir(node: Node, config_file_path: impl AsRef<Path>) -> Option<std::path::PathBuf> { |
There was a problem hiding this comment.
There's a consistency argument to make for this remaining as std::path::Path and the other usages of that to do the same and remove the use std::path::Path since all other std stuff comes in via the fully qualified name.
There was a problem hiding this comment.
IMO we probably ought to go the other way and have use imports for everything in std (unless there's a name clash)
|
This is similar to one that is in Peniko: linebender/peniko#33 and another in Kurbo: linebender/kurbo#346 |
| node: Node, | ||
| config_file_path: impl AsRef<std::path::Path>, | ||
| ) -> Option<std::path::PathBuf> { | ||
| fn resolve_dir(node: Node, config_file_path: impl AsRef<Path>) -> Option<std::path::PathBuf> { |
There was a problem hiding this comment.
IMO we probably ought to go the other way and have use imports for everything in std (unless there's a name clash)
This helps point out where the code can be more concistent with an identifier already being in scope and not needing qualifications.
waywardmonkeys
force-pushed
the
fix-unused-qualifications
branch
from
9edcfa5 to
839f7e7
Compare
| @@ -7,6 +7,7 @@ members = [ | |||
| [workspace.package] | |||
| edition = "2021" | |||
| # Keep in sync with RUST_MIN_VER in .github/workflows/ci.yml and with the relevant README.md files. | |||
| # TODO: When this hits 1.74, move lint configuration into this file via a lints table. | |||
There was a problem hiding this comment.
We don't need to wait for the MSRV to be that high to use the lints table. The MSRV cargo check commands won't fail, they'll just warn that there is an unused manifest key but the CI will still pass. The stable toolchain will do the actual linting.
This won't be a problem for projects higher up the stack either, as Cargo doesn't complain about unused manifest keys of dependencies.
Opened #61 to resolve this.
This helps point out where the code can be more concistent with an identifier already being in scope and not needing qualifications.