Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic CI support for packages without the std feature. #63

Merged
merged 1 commit into from
May 23, 2024

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented May 23, 2024

With #55 we introduced a package that doesn't have the std feature. The CI was adjusted to cope with that.

This PR here improves support for such packages in key ways:

  • Automatically support it using the --ignore-unknown-features flag.
  • Remove the manual listing of PRIMARY_PKGS and EXAMPLE_PKGS and restore usage of --workspace so that the CI will automatically pick up new packages.
  • Restores support for "primary packages" that don't need to follow MSRV.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@xStrom xStrom added this pull request to the merge queue May 23, 2024
Merged via the queue into linebender:main with commit eb2c68a May 23, 2024
19 checks passed
@xStrom xStrom deleted the robustci branch May 23, 2024 14:03
xStrom added a commit to xStrom/parley that referenced this pull request May 23, 2024
This reverts commit 49e055a.

Revert "Add automatic CI support for packages without the `std` feature. (linebender#63)"

This reverts commit eb2c68a.

Revert "tiny_skia_render: Fix unused qualifications. (linebender#62)"

This reverts commit f7f339b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants