Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for decoding WebP images #747

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

notjosh
Copy link
Contributor

@notjosh notjosh commented Apr 21, 2024

Hiya 👋

I was hoping to use WebP in a project, and noticed (via #575) that the image-webp project has been published now. This PR adds support for the project within resvg.

As noted in #575 there may be performance issues - I haven't tested extensively. However in my use case, it saves a step of converting .webp images to a compatible format, so even a slow(ish) implementation is an overall positive. With that in mind, it feels like a step forward for resvg to support WebP, even if there's still room in future for their (pre-1.0) project to improve.

@RazrFalcon
Copy link
Collaborator

Looks good to me. All we have to do now is to ask them nicely to stop using thiserror.

@RazrFalcon
Copy link
Collaborator

image-rs/image-webp#66

@RazrFalcon
Copy link
Collaborator

Looks like we need a MSRV bump as well.

@RazrFalcon
Copy link
Collaborator

Ok, waiting for 0.1.3 and I'm ready to merge.

@adamJLev
Copy link

any updates on this? would be great to have webp support ❤️

@LaurenzV
Copy link
Contributor

Still waiting for the new release I think.

@notjosh
Copy link
Contributor Author

notjosh commented Jul 17, 2024

0.1.3 was just released, so I'll rebase & clean up the PR soon....ish. I've got some family in town so it might be a couple of days.

@RazrFalcon
Copy link
Collaborator

Sure, no problem.

@notjosh
Copy link
Contributor Author

notjosh commented Jul 22, 2024

Okie doke, tests are green locally, so this should now be ready to review.

@notjosh
Copy link
Contributor Author

notjosh commented Jul 22, 2024

error: package image-webp v0.1.3 cannot be built because it requires rustc 1.67.1 or newer, while the currently active rustc version is 1.65.0

How much of a dealbreaker is this? And/or as image-webp is an optional dependency, anyone that doesn't want to opt into the feature can continue to use < 1.67.1 version, I guess?

@RazrFalcon
Copy link
Collaborator

We can bump MSRV no problem. It's set in:

  • .github/workflows/main.yml
  • README.md

@notjosh
Copy link
Contributor Author

notjosh commented Jul 24, 2024

@RazrFalcon bumped MSRV, can you approve workflow? tyty.

Also, do you want me to bump CHANGELOG.md within the PR, or do you author those (for consistency etc)?

@RazrFalcon RazrFalcon merged commit 34b9b4c into linebender:master Jul 24, 2024
3 checks passed
@RazrFalcon
Copy link
Collaborator

All good, thanks.

@notjosh notjosh deleted the feature/webp branch July 25, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants