-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for decoding WebP images #747
Conversation
Looks good to me. All we have to do now is to ask them nicely to stop using |
Looks like we need a MSRV bump as well. |
Ok, waiting for 0.1.3 and I'm ready to merge. |
any updates on this? would be great to have webp support ❤️ |
Still waiting for the new release I think. |
0.1.3 was just released, so I'll rebase & clean up the PR soon....ish. I've got some family in town so it might be a couple of days. |
Sure, no problem. |
Okie doke, tests are green locally, so this should now be ready to review. |
How much of a dealbreaker is this? And/or as |
We can bump MSRV no problem. It's set in:
|
@RazrFalcon bumped MSRV, can you approve workflow? tyty. Also, do you want me to bump |
All good, thanks. |
Hiya 👋
I was hoping to use WebP in a project, and noticed (via #575) that the
image-webp
project has been published now. This PR adds support for the project withinresvg
.As noted in #575 there may be performance issues - I haven't tested extensively. However in my use case, it saves a step of converting
.webp
images to a compatible format, so even a slow(ish) implementation is an overall positive. With that in mind, it feels like a step forward forresvg
to support WebP, even if there's still room in future for their (pre-1.0) project to improve.