Round hues in HSL to RGB conversion #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks good to me on a first glance, but could you rebase it and your other PR forward so that they are using the updated CI checks that we just landed today? Also, it might be good to talk with you about some of what we're doing in the Linebender organization with color (and our |
erxclau
force-pushed
the
hsl-to-rgb-round
branch
from
51075f8 to
4ada144
Compare
DJMcNab
approved these changes
Dec 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
erxclau
force-pushed
the
hsl-to-rgb-round
branch
from
4ada144 to
3aa92b0
Compare
|
Rebased this to fix a test case from #31 to expect new rounding behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current float to integer cast truncates the hues when converting from HSL to RGB. This PR rounds to the nearest integer before the cast.
See linebender/resvg#786 for discussion.
Modifies tests with
hsl(120, 100%, 75%, 0.5)to match withrgb(128, 255, 128)and adds one new test case.Chrome developer tools:
Safari developer tools:
