Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fello version #352

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Update fello version #352

merged 1 commit into from
Aug 7, 2023

Conversation

dfrg
Copy link
Collaborator

@dfrg dfrg commented Aug 7, 2023

This brings in experimental CFF/CFF2 support.

@dfrg
Update fello version
5ee5eb6 
This brings in experimental CFF/CFF2 support.
waywardmonkeys
waywardmonkeys approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what to verify here other than it passing CI … so this is a rubber stamp unless there is something else I can help to validate.

@dfrg
Copy link
Collaborator Author

dfrg commented Aug 7, 2023

There was a fairly small change to fello to pull in code from the google fonts repo for CFF support. This shouldn't break anything that was already working. If there are problems with the CFF code, maybe we'll catch them in xilem. Thanks!

@dfrg dfrg merged commit 3cb5462 into main Aug 7, 2023
4 checks passed
@dfrg dfrg deleted the update-fello branch August 7, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfrg @waywardmonkeys