Match CI doc testing with docs.rs. #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
approved these changes
Nov 5, 2024
vello/src/wgpu_engine.rs
Outdated
| @@ -38,7 +38,7 @@ pub(crate) struct WgpuEngine { | |||
| #[cfg(not(target_arch = "wasm32"))] | |||
| shaders_to_initialise: Option<Vec<UninitialisedShader>>, | |||
| pub(crate) use_cpu: bool, | |||
| /// Overrides from a specific `Image`'s [`id`](peniko::Image::id) to a wgpu `Texture`. | |||
| /// Overrides from a specific `Image`'s [`id`](peniko::Blob::id) to a wgpu `Texture`. | |||
There was a problem hiding this comment.
Feel like this might be better phrased to indicate that the id comes from the image's blob ...
waywardmonkeys
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Zunstable-options -Zrustdoc-scrape-examplesfrom CI. It wasn't even enabled for docs.rs and we don't have any examples by Cargo's definition, so not worth enabling scraping at this point.rustdocbugs giving false positives but I got it to pass without failure right now, so perhaps better times have arrived.--all-featuresat docs.rs to match our CI and reduce the maintenance burden of manually syncing the features list.x86_64-unknown-linux-gnuon docs.rs as we don't have any platform specific docs.doc_auto_cfgfeature for docs.rs which will show a little tip next to feature gated functionality informing of the crate feature flag.