Default to a line height of 1.2

https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#normal
linebender · Nov 22, 2024 · e9e974f · e9e974f
1 parent d8d916c
commit e9e974f
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 7 deletions.
diff --git a/masonry/src/text/styleset.rs b/masonry/src/text/styleset.rs
@@ -15,6 +15,10 @@ impl<Brush: parley::Brush> StyleSet<Brush> {
     pub fn new(font_size: f32) -> Self {
         let mut this = Self(Default::default());
         this.insert(StyleProperty::FontSize(font_size));
+        // Emulate: https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#normal
+        // This is a more sensible default that Parley's default.
+        // We expect Parley to make a different choice here at some point?
+        this.insert(StyleProperty::LineHeight(1.2));
         this
     }
 

diff --git a/masonry/src/widget/screenshots/masonry__widget__flex__tests__col_main_axis_end.png b/masonry/src/widget/screenshots/masonry__widget__flex__tests__col_main_axis_end.png
diff --git a/.../src/widget/screenshots/masonry__widget__label__tests__label_alignment_flex.png b/.../src/widget/screenshots/masonry__widget__label__tests__label_alignment_flex.png
diff --git a/masonry/src/widget/screenshots/masonry__widget__label__tests__line_break_modes.png b/masonry/src/widget/screenshots/masonry__widget__label__tests__line_break_modes.png
diff --git a/masonry/src/widget/screenshots/masonry__widget__label__tests__styled_label.png b/masonry/src/widget/screenshots/masonry__widget__label__tests__styled_label.png
diff --git a/.../src/widget/screenshots/masonry__widget__prose__tests__prose_alignment_flex.png b/.../src/widget/screenshots/masonry__widget__prose__tests__prose_alignment_flex.png
diff --git a/...nry/src/widget/screenshots/masonry__widget__textbox__tests__textbox_outline.png b/...nry/src/widget/screenshots/masonry__widget__textbox__tests__textbox_outline.png