Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the generic Linebender CI script. #135

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Sep 11, 2023

Having a unified CI script across projects reduces the maintenance burden and allows every project to quickly benefit from lessons learned across all the projects.

The new script in this PR is basically a copy of Glazier's current CI script. It has been designed with the explicit goal of being widely applicable across Linebender projects. It has worked well for Glazier and now is the time to also bring it to Xilem.

Once merged, this will also open up the path to enabling merge queues for Xilem.

Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't look at all of this in detail right now, but you'll have to update the README badge for the build / actions since it is getting renamed here. (I like the renaming.)

Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, actions/checkout@v4 is out now: https://github.com/actions/checkout/releases/tag/v4.0.0

@xStrom
Copy link
Member Author

xStrom commented Sep 11, 2023

Fixed README.md and upgraded actions/checkout. Ready for another look.

@xStrom xStrom merged commit 3465dde into linebender:main Sep 12, 2023
7 checks passed
@xStrom xStrom deleted the newci branch September 12, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants